Skin bugs in DefaultWideHD (1 Viewer)

[CyberSimian]

No Channel Name Displayed For Result Of "Search In Titles"
I used the "search in titles" facility to search for programme titles containing a particular string, and I got some hits. The problem is that I cannot tell on which channel the programme is being broadcast, viz:



Is it possible to add this information? (I guess it depends on whether the skin engine exposes this information for this panel.) Also, if it is possible, it ought to be changed for radio programme search as well as TV programme search. I am using MP 1.16 pre-release. Thanks.

-- from CyberSimian in the UK

 

[catavolt]

Seems you don´t have any channel logos installed??? Normally the logo of the respective channel is displayed

But here the corrected xml

 

[CyberSimian]

Seems you don´t have any channel logos installed?

Yes, that is correct. I am probably in the minority, but I much prefer word labels rather than mystifying graphic symbols.

I don't wish to be picky, but does the corrected XML file fix the "Radio Programme Search" panel too? I cannot test the new file at the moment , as my test system is the same as my production system, and the latter is in use for productive work (i.e. recording TV!). I browsed the new XML file, but did not find a single reference to "radio". But perhaps the file is common to TV and radio (so both are fixed)?

-- from CyberSimian in the UK

 

[CyberSimian]

But here is the corrected xml

I have now had a chance to test this. Thank you for providing the fix so quickly! The solution supplies the missing information, so that is good. However...

I was a bit surprised that you included the channel name with the programme title. I had expected it to be more consistent with other panels. When you select a future programme from the EPG, you get this:



which has the channel name on the same line as the programme start and end times (near the bottom of the panel). Even better, each programme in the list is prefixed with the channel name (so it is easy to distinguish the episodes broadcast on HD channels from those broadcast on SD channels). The list could be improved by adding a separator char between the channel name and programme title (but in reality the programme title is unnecessary for entries in the list).

Another quirk of the current fix (may be curable?) is that you get a trailing "-" char on the programme title near the bottom of the panel that precedes the list of found episodes, like this:



Selecting the required programme gives the list of episodes:



On this panel, the programme title in the entries in the list could be replaced by the channel name, since the programme title is already shown near the top of the panel, and shown again with the programme details near the bottom of the panel.

Finally, the "Radio Search" panels look as though they need a more radical overhaul:



I cannot see any reason why this panel should be different to the corresponding "TV Search" panel. The existing data needs to be moved to the right, and the left side-bar menu brought permanently on screen (as it is in "TV Search").

All in all, it looks as though there is a lot of work involved here, probably too much for MP 1.16. But I cannot see any rational reason for radio and TV being different, and I do hope that you will be able to improve DefaultWideHD along the lines suggested in the weeks/months ahead. Thank you.

-- from CyberSimian in the UK

 

[catavolt]

When you select a future programme from the EPG, you get this:

Different screen and different properties -it is hardcoded and therefore the skinner is limited in what properies to use and how
This applies to your other remarks, too

 

[CyberSimian]

I have been tweaking some skin files in the last few days, and I noticed the following "quirks" in the "DefaultWideHD" skin (it is MP 1.16 pre, but not the most recent one):

Background Shows Through Too Strongly in TV Guide



Preview Thumbnail Overlays Text in Radio Guide




Preview Thumbnail Overlays Current Date and Time on "Home" Panel
(Suggestion: move the thumbnail to the left side of the panel.)



-- from CyberSimian in the UK

 

[CyberSimian]

What is the correct spelling of the "colorDiffuse" tag?

I am continuing with my tweaks to the old "DefaultWide"skin, during which I have noticed some occurrences of the "colordiffuse" tag spelled "colorDiffuse". I noticed this because I was trying to change the colour value, and it was having no effect. After changing the spelling to "colordiffuse", my new colour value took effect.

Well... I decided to scan the "DefaultWide" XML files for other occurrences, and found about a dozen of them. Then I decided to scan "DefaultWideHD" (@catavolt) and found 86 occurrences, and "Ares" (@wizard123) has 7 occurrences.

Now, it did occur to me that this misspelling may be intentional. The desire may have been to retain the line for documentation purposes, without the line having any effect. Misspelling the tag name would be one way of doing that. Was that the intention? If not, I can append a list of files that need fixing.

Finally, I feel compelled to remark that having case-sensitive tag names is (in my view) a poor choice. As far as I know, tag names in HTML are not case sensitive.

-- from CyberSimian in the UK

 

[mm1352000]

What is the correct spelling of the "colorDiffuse" tag?

If anything it is colordiffuse - all lower case.

I noticed this because I was trying to change the colour value, and it was having no effect.

Specify the context (window, dialog or whatever) please.

[edit: By the way...

Finally, I feel compelled to remark that having case-sensitive tag names is (in my view) a poor choice. As far as I know, tag names in HTML are not case sensitive.

You're not dealing with HTML; you're dealing with XML, which is case sensitive..

 

[ajs]

What is the correct spelling of the "colorDiffuse" tag

https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControl.cs#L114

[XMLSkinElement("colordiffuse")] protected long _diffuseColor = 0xFFFFFFFF;

 

[CyberSimian]

You're not dealing with HTML; you're dealing with XML, which is case sensitive..

Specify the context (window, dialog or whatever) please.

After I changed the spelling, it worked as expected (so no problem for me, but it may be a problem for "DefaultWideHD" and "Ares").

Unfortunately, MP seems to have ended up with a confusing mixture of letter case. The correct spelling of "colorDiffuse" is "colordiffuse", but the correct spelling of "wrapstring" is wrapString". "Amped" spells the "colorkey" tag as "colorkey", but spells the "colorkey" attribute as "colorKey" (on the "border" tag). And then there the others: shadowAngle, shadowDistance, shadowColor, textcolorNoFocus, textureNoFocus, ... (the file "references.xml" has a good selection).

-- from CyberSimian in the UK