Stop button doesn't work with fullscreen with TVClient (1 Viewer)

Paranoid Delusion

Moderation Manager
  • Premium Supporter
  • June 13, 2005
    13,052
    2,978
    Cheshire
    Home Country
    United Kingdom United Kingdom
    If user presses "by accident" the power button, not only the timeshifting will be lost but the whole system shuts down..

    Good scenario, thats why the mce remotes powerbutton is recessed though, so it does take a deliberate action to press.

    Guys, this discussion ain't going nowhere, we've already said the reasoning behind this is not going to change, so can we agree this is how it works.

    Thanks
     

    bolders

    Portal Pro
    February 1, 2007
    84
    6
    Home Country
    United Kingdom United Kingdom
    I have achieved this behaviour by using the Macro function in IR server suite.

    I have created a macro that jumps to the TV home screen then sends a "b" keystroke to stop the TV.

    I have added this into the remote control mappings using the condition that fullscreen TV must be playing for the Macro to be activated instead of the standard "stop" command.

    (remember when setting conditions in remote mappings, actions that rely on a particular condition must be above the no condition action - I always forget this)

    bolders
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #13
    If user presses "by accident" the power button, not only the timeshifting will be lost but the whole system shuts down..

    Good scenario, thats why the mce remotes powerbutton is recessed though, so it does take a deliberate action to press.

    Guys, this discussion ain't going nowhere, we've already said the reasoning behind this is not going to change, so can we agree this is how it works.

    Thanks

    Well none of the reasoning presented in this thread doesn't make any sense. It should ring some bells if someone like bolders here has to do some macros to achieve the desired behaviour. Maybe I'll just write my on patch then.
     

    SciDoctor

    Retired Team Member
  • Premium Supporter
  • February 2, 2005
    1,465
    139
    England
    We move into the addition of a new feature request but what would be desireable outside the present feature freeze would be the addition of a 'yes/no' dialogue box when ever the stop button is pressed and the timeshift is active (even in sub screens)

    I fully understand the possible confusion of the stop button being inactive in fullscreen for a lay-user but it its present function is as-is for protection .

    In response to bolders unique approach, what happens when you have had to pause live tv to do something else for possibly half an hour and in your rush to get back to the unmissable you press your remote incorrectly and the 'stop' is activated instead of play !!!
     

    bolders

    Portal Pro
    February 1, 2007
    84
    6
    Home Country
    United Kingdom United Kingdom
    I think there are arguments for both methods and im sure the devs have put a lot of thought into which direction to take. They put in a hell of a lot of work and I think its their perogative to have the last word (you can never please everyone).

    The beauty of MP is that if you dont like things a particular way they can be changed to your particular preference from writing your own plugin or using the work that somebody else has donated (in my case im building on the the efforts of and-81 as I dont have the expertise to write my own plugin. I know some VBA and thats pretty much it - my point being you dont need to be a programmer to accomplish many of these tasks)

    bolders
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #16
    About 20 lines of code and now the stop button is working as I wanted :)
     

    bolders

    Portal Pro
    February 1, 2007
    84
    6
    Home Country
    United Kingdom United Kingdom
    Nice

    care to share the code with those who prefer to have fullscreen live TV stop when stop button pressed

    cheers

    bolders
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #18
    Some dev could confirm is this correct, simple version without the confirm dialog:

    TVFullScreen.cs starting at line 892:

    case Action.ActionType.ACTION_STOP:

    if (g_Player.IsTimeShifting || g_Player.IsTVRecording)
    {
    g_Player.Stop();
    // switch back to the menu
    _isOsdVisible = false;
    _msnWindowVisible = false;
    GUIWindowManager.IsOsdVisible = false;
    GUIGraphicsContext.IsFullScreenVideo = false;
    GUIWindowManager.ShowPreviousWindow();
    return;
    }
    break;
     

    Users who are viewing this thread

    Top Bottom