[Approved] String comparison logic for the visible property of skin elements (1 Viewer)

[ZealotSix]

I would like to be able to use string comparison logic for the visible property of skin elements. For example, if a skin designer would like an element to be visible if a particular plugin's property (PropertyX) is a certain value ("foo") and PropertyY is a value "bar", he could use something like the following psudocode:

<visible>String.Equals(#MyPlugin.PropertyX,foo) + String.Equals(#MyPlugin.PropertyY,bar)</visible>

Is something like this currently possible with any of the existing values of the Visible property?

If not, I will be interested in writing a patch to add this functionality. I would like to hear suggestions from others on preferred syntax.

Thanks,
Travis

 

[ZealotSix]

Please consider this patch for inclusion in MediaPortal 1.0.2. (or the next non-critical release of 1.x)

After researching the code for the above question, I found that there is a setting intended to accomplish this very goal called skin.string(val1,val2). Unfortunately however there were some bugs with this which caused it to never evaluate true because the first string would always resolve to "", no matter what the skin designer entered.

I have fixed the bug in the attached patch. It will now compare string1 to string2, and evaluate true if they match. It leverages GUIPropertyManager.Parse in order to resolve any properties that were set by skins.

Thanks!
Travis

 

[ltfearme]

Can someone move this to the patches thread so the DEVs have visibility.

 

[chemelli]

Commited to SVN22943.



Simone

 

[SilentException]

anyone got this to work properly? i'm testing like this
<define>#use_star_rating:yes</define>

<control>
<description>IMDB Rating</description>
<type>fadelabel</type>
<id>905</id>
<posX>800</posX>
<posY>360</posY>
<width>180</width>
<label>#use_star_rating</label>
<font>font13</font>
<visible>!String.Equals(#use_star_rating,yes)+Control.IsVisible(24)</visible>
</control>

any pointers?



EDIT: d'oh, it cannot be used with <define> properties.. pitty

 

[Harley]

like it is in svn now, is there a description for using it in the Wiki ??

Realy important , by all adding new stuff is to hold the wiki actuall !!

Greetings Harley

 

[ltfearme]

I think now that this functionality exists, plugin developers probably dont need to use dummy controls any more...we could just set a skin property and skinners can just use the string.equals function to evaluate conditions.