SubtitleDownloader (1 Viewer)

[seco]

I was thinking that I could change ExtractFilesFromZipOrRarFile to extract full directory structure and return that as a List<FileInfo>, I think that should not break any existing implementations and would work for sous-titres.eu too.

What do you think MrJul?

 

[MrJul]

Seems fine with me @seco. From my point of view, I just have to filter extracted files rather than filtering what to extract so everything should work the same.

 

[doskabouter]

Nice work seco! I've successfully incorporated it in the onlinevideos plugin (for some sites only).

I do have one question:
If I specify multiple languages, it makes 2 calls (one with the first language in it, and one with both of them), and it seems that it's a bit waste of time.

Tested it with podnapisi, and languages="dut","eng".
Perhaps this behaviour is dependent on the implementation of this specific one, but thought I'd mention it anyway.

 

[seco]

Nice work seco! I've successfully incorporated it in the onlinevideos plugin (for some sites only).

I do have one question:
If I specify multiple languages, it makes 2 calls (one with the first language in it, and one with both of them), and it seems that it's a bit waste of time.

Tested it with podnapisi, and languages="dut","eng".
Perhaps this behaviour is dependent on the implementation of this specific one, but thought I'd mention it anyway.

Glad to see that we can use this in Online Videos too I guess it is not possible to make a SubCentral support for OnlineVideos since you decided to use SubtitleDownloader directly?

What you said about languages is correct, if the site does not support searching with multiple languages the only way to do this is to make multiple requests.

 

[doskabouter]

I don't think that subcentral support is possible right now, for that, the core would need some adjustments, but if I'm nagged enough by users, I probably will give it a shot

As for the multiple calls: perhaps you didn't fully understand what I'm trying to say: the first call queries for one language, and the second queries for 2 languages

 

[seco]

I don't think that subcentral support is possible right now, for that, the core would need some adjustments, but if I'm nagged enough by users, I probably will give it a shot

That's cool. Currently the plugin support in SubCentral is achieved by creating a PluginHandler, for example MP-TVSeries: http://code.google.com/p/subcentral/source/browse/trunk/SubCentral/PluginHandlers/TVSeriesHandler.cs

As for the multiple calls: perhaps you didn't fully understand what I'm trying to say: the first call queries for one language, and the second queries for 2 languages

You might be onto someting, I need to re-check the implementation...

EDIT: It seems the only flaw is that the language parameter is appended to the end of the query without removing the previous, but only last value is used since there is no support for query with multiple languages.

 

[Spas]

Where can I download the .DLL directly? I cannot seem to find it on the project site.

I cannot find the download link either. On the downloads page, the only clickable link is for the MPEI thingy.

 

[doskabouter]

The mpei is ok, it has the benefit of getting notified if updates are available (in the mpei installer)

 

[seco]

Yeah but for non-Mediaportal projects the DLL is enough Which I see is not currently available at the project page, will fix this soon...

 

[Spas]

Yeah but for non-Mediaportal projects the DLL is enough Which I see is not currently available at the project page, will fix this soon...

Exactly - I am working on a non-Mediaportal project, so I would like the DLL

Thanks!