[fixed] Switching TV channel from AC3 to MPEG audio fails (1 Viewer)

tourettes

Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Could somebody provide some logs with SVN >=25151 ? Problem could be solved by this one.

    I'm absolutly not able to reproduce the issue with 252xx and I would avoid to revert SVN on main HTPC.:(

    Here
     

    Attachments

    • MPEG1_to_AC3_freeze.zip
      30.7 KB

    Ambass

    Retired Team Member
  • Premium Supporter
  • December 24, 2007
    555
    129
    Home Country
    France France
    Problem seems occuring only with MS-DTV "Video"..?!?! ( this is an evidence when you change audio...;)), and it's not the same related at the beginning of this thread (Already solved).
    I suppose in some ( or all ) cases ( why ? ) the :mad: M$ filter need to be disconnected/reconnected.
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Problem seems occuring only with MS-DTV "Video"..?!?! ( this is an evidence when you change audio...;)), and it's not the same related at the beginning of this thread (Already solved).
    I suppose in some ( or all ) cases ( why ? ) the :mad: M$ filter need to be disconnected/reconnected.

    Indeed it seems that the latest graph building changes are causing MS DTV-DVD video decoder to hang on audio stream type change. Why is that? It was not the case earlier and I'm pretty sure that graph connections were renewed for the video part only if the video stream type was changed. Here's the old code related to video pin reconnection:

    Code:
                switch (iChangedMediaTypes)
                {
                  case 1: // audio changed
                    Log.Info("Reconnecting audio pin of tsreader filter.");
                    ReConnectPin("Audio");
                    break;
                  case 2: // video changed
                    Log.Info("Reconnecting video pin of tsreader filter.");
                    ReConnectPin("Video");
                    break;
                  case 3: // both changed
                    Log.Info("Reconnecting audio pin of tsreader filter.");
                    ReConnectPin("Audio");
                    Log.Info("Reconnecting video pin of tsreader filter.");
                    ReConnectPin("Video");
                    break;
                }
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Following hack seems to do the trick... but I don't like it :)

    1) if user has configured some other than MS video decoder and MS decoder is used as DS fail back codec the issue is still available
    2) doesn't fix any other codecs than MS video decoder caused issue
     

    Attachments

    • MPEG1_AC3_hack.patch
      30.6 KB

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: Switching TV channel from AC3 to MPEG audio fails

    @rksmith
    it coasts a lot of speed while changing channel
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    New patch, should solve the issue with MS decoder. Causes a pause with audio stream type change.
     

    Attachments

    • MPEG1_to_AC-3_patch_for_MS.patch
      30.7 KB

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: Switching TV channel from AC3 to MPEG audio fails

    here too - only bad that we need a special fix for MS DTV Codec? Isn't there a general way to detect if a codec needs a reconnect or not?
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Re: AW: Switching TV channel from AC3 to MPEG audio fails

    here too - only bad that we need a special fix for MS DTV Codec? Isn't there a general way to detect if a codec needs a reconnect or not?

    No, since codec doesn't tell it to us :) But hopefully there is something that is done wrong on MP side that causes the issue in first place. Manfred is currently looking into it since he knows the current graph building code best.
     

    Users who are viewing this thread

    Top Bottom