Syntax error in line xxxx (1 Viewer)

[vuego]

MediaPortal Version: 1.2.3

Description
I started getting this error when playing a specific video file. I have several plugins installed and the error message doesn't give much clue of what the problem is. After clicking OK the video plays normally however I did not get any subtitles displayed. Turns out the .srt file was missing a decimal.

The error message isn't very HTPC friendly and doesn't help the user understand what's going on.
Proposal: Skip the Windows popup window and instead display a message in MediaPortal's GUI which mentions that the subtitle won't be loaded. Even better would be if the subtitle reader could be smart enough to add the missing decimal

Steps to Reproduce:
Play a video with an external subtitle file that's missing a decimal like in this example:

1
00:00:05,000 --> 00:00:07,000
No problem with this line.
 
2
00:00:08 --> 00:00:13,000
This line will make MP throw
a Syntax Error message box.

Notice the missing ",000" on the second line.
Attached log files and a sample .srt subtitle file.

 

[Scythe42]

This is an easy fix not to show an error or even adding missing decimals. Opened Mantis: http://mantis.team-mediaportal.com/view.php?id=3944

 

[Sebastiii]

Thanks for srt sample

 

[Sebastiii]

From my test on current branch fix, it seems that it's an error from MPC-HC Engine that lead to do not load .SRT.
Testing with ffdshow engine and only culprit line is not displayed.
Will try later with MPC-HC to confirm.

 

[Sebastiii]

Hey,
Was quick, i can confirm it's MPC-HC subtitle code to fix

So i assume the current fix it's when using subtitle renderer (TV side)

 

[Scythe42]

Wrong location, but should be easy to apply the regex to C++ as well.

Shouldn't the subtitle engine be updated in general first?

 

[Sebastiii]

There is a branch with latest MPC-HC Engine, i have tested on it and on master and it's the same.
I have ask MPC-HC guys to know if they can fix it

 

[Scythe42]

Provide them with my regex. They can export it to C++ from Expresso and also test it in there on various SRT files.

It's designed to load the whole file and then return the individual components in each matching block with captures.

 

[Sebastiii]

Hi,

MPC-HC Team has fixed the issue , i have port the change into MPC-HC-SUBS branch

New bin on : https://forum.team-mediaportal.com/threads/update-subtitle-mpc-hc-engine.113293/
Workng for me
Seb.