Reply to thread

Message

<blockquote data-quote="rtv" data-source="post: 239909" data-attributes="member: 12309">I wonder who did that...[CODE]315 System.ServiceProcess.ServiceController ctrl = new System.ServiceProcess.ServiceController(&quot;TVService&quot;);316 try 317 { 318&nbsp;&nbsp; string name = ctrl.ServiceName; 319 } 320 catch (Exception) 321 { 322&nbsp;&nbsp; ctrl = null; 323&nbsp;&nbsp; Log.Info(&quot;Main: TvServer not installed, so we can go on.&quot;); 324 }[/CODE]There are various issues with this code.1. Exceptions are bad for performance - a simple &quot;== null&quot; check for ctrl would have been better. 2. The ServiceController's Konstruktor needs priviledged access. It's call however is NOT in the try-catch block. So if some user does not run MP with Administrator rights (after installation) this will fail.Here are some docs:<a href="http://msdn2.microsoft.com/en-us/library/s3ket56y.aspx" target="_blank">ServiceController Constructor (String) (System.ServiceProcess)</a>In general the current implementation can hardly be considered more than a workaround. And if even that might cause troubles <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite11" alt=":rolleyes:" title="Roll Eyes&nbsp; &nbsp; :rolleyes:" loading="lazy" data-shortname=":rolleyes:" /></blockquote>

[QUOTE="rtv, post: 239909, member: 12309"] I wonder who did that... [CODE] 315 System.ServiceProcess.ServiceController ctrl = new System.ServiceProcess.ServiceController("TVService"); 316 try 317 { 318 string name = ctrl.ServiceName; 319 } 320 catch (Exception) 321 { 322 ctrl = null; 323 Log.Info("Main: TvServer not installed, so we can go on."); 324 } [/CODE] There are various issues with this code. 1. Exceptions are bad for performance - a simple "== null" check for ctrl would have been better. 2. The ServiceController's Konstruktor needs priviledged access. It's call however is NOT in the try-catch block. So if some user does not run MP with Administrator rights (after installation) this will fail. Here are some docs: [url=http://msdn2.microsoft.com/en-us/library/s3ket56y.aspx]ServiceController Constructor (String) (System.ServiceProcess)[/url] In general the current implementation can hardly be considered more than a workaround. And if even that might cause troubles :rolleyes: [/QUOTE]

Verification