[fixed] TV Server crashes with unknown error (related to KNC tuners) (1 Viewer)

[mm1352000]

Branch created:
https://github.com/MediaPortal/Medi...BUG-Use_of_KNC_API_DLL_causes_TV_Server_crash

 

[elliottmc]

Branch created:
https://github.com/MediaPortal/Medi...BUG-Use_of_KNC_API_DLL_causes_TV_Server_crash

Thanks. How much review is needed for this? Since only one thing is changed, this should be simple enough to get approved and merged.

 

[mm1352000]

How much review is needed for this?

Probably very little if any.
The use of cdecl in the previous code is a logical and functional error. The SDK/API which I have tells us that the functions are implemented/declared as stdcall in the DLL. Hence it is incorrect to use cdecl and correct to use stdcall. We see the proof in that the patch solves the problem. @morpheus_xx also found this problem when TVE 3.5 went to .NET 4:

Diposing KNC library (probably only side effect) Fixed: [12:40] <MP1-GitBot> [MediaPortal-1] morpheusxx pushed 2 new commits to EXP-TVE3.5_MP_NET4: http://git.io/wFxHng

http://git.io/wFxHng
https://forum.team-mediaportal.com/threads/planning-work-on-native-mp2-tvengine.110399/

IMO this could be merged immediately...

 

[elliottmc]

How much review is needed for this?

Probably very little if any.
The use of cdecl in the previous code is a logical and functional error. The SDK/API which I have tells us that the functions are implemented/declared as stdcall in the DLL. Hence it is incorrect to use cdecl and correct to use stdcall. We see the proof in that the patch solves the problem. @morpheus_xx also found this problem when TVE 3.5 went to .NET 4:

Diposing KNC library (probably only side effect) Fixed: [12:40] <MP1-GitBot> [MediaPortal-1] morpheusxx pushed 2 new commits to EXP-TVE3.5_MP_NET4: http://git.io/wFxHng

https://forum.team-mediaportal.com/threads/planning-work-on-native-mp2-tvengine.110399/

IMO this could be merged immediately...

You know what you are doing. Go for it.

 

[applebee1]

Perfect patch - working again without problems...
Thanks a lot!

 

[mm1352000]

Done.
Branch merged and deleted. Also cleaned up some of my other old branches.
Marking thread as fixed.
Thanks everyone!

 

[Holzi]

Thanks!
Maybe you can also take care of the Jira entry.

 

[mm1352000]

Thanks!
Maybe you can also take care of the Jira entry.

Sorry, you shouldn't have to ask me to do that.
Done.