[Rejected] TVE3 fix for com error when timeshifting.patch (1 Viewer)

[framug]

Simple tortoise patch convert for com error with no SVN integration yet discussed here :
https://forum.team-mediaportal.com/...nd-tv-server-90/noob-tvserver-question-55693/ on #8 start post.

This patch is for all DVB card owner and not only for personal use.

Think of the day : Patches can't be only for personal use, if there is a possibility that at least one guy can be in the same situation.
Personal use is when you do something for your own use and, you keep it for yourself, without sharing.

 

[morpheus_xx]

I quote myself here:

I have a com error :

2009-04-14 07:21:20.437500 [6]: dvb:AddNetworkProviderFilter
2009-04-14 07:21:20.468750 [6]: Error while checking if a com object is installed - b2f3a67c-29da-4c78-8831-091ed509a475 - System.Runtime.InteropServices.COMException (0x80040154): La récupération de la fabrique de classe COM pour le composant avec le CLSID {B2F3A67C-29DA-4C78-8831-091ED509A475} a échoué en raison de l'erreur suivante : 80040154.
   à System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
   à System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
   à System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
   à System.Activator.CreateInstance(Type type, Boolean nonPublic)
   à TvLibrary.Implementations.DVB.FilterGraphTools.IsThisComObjectInstalled(Guid clsid)

I looked on your modification. I don't think that it is required to query registry before call of "IsThisComObjectInstalled", because that is what this function is for.

The flaw here is inside the checking function, it logs the exception, what isn't required. it should simply return false....

The "IsThisComObjectInstalled" should catch Exception and return "false" only.

But thank you for remembering us

 

[framug]

Hi morpheus_xx,

Sorry to annoy you by quoting yourself again, if any.
It has been written that better solution was to provide patches here instead of Bugreportforums.
That's why I posted here again.
By the way, this post was exactly made for remember about this issue, whatever the coding way wich it can be done.
Only the final result (fixing this error) is important, IMHO.
Then, when it will be done, you could, if you want, ending this post ([Approved], [Rejected], [Closed], [WhatYouWant]).
Thx and Best Regards.

 

[morpheus_xx]

fixed by removing useless log: 0002228: Testing for Generic Network Provider logs useless exceptions - MediaPortal Bugtracker

 

[framug]

OK morpheus_xx,

Many thanks for fixing it.
Let's see for another patch very very soon, then.

HS for info : A friend just tell me about Natal project did you know it ? Amazing.
YouTube - Project Natal

 

[infinite.loop]

HS for info : A friend just tell me about Natal project did you know it ? Amazing.
YouTube - Project Natal

please keep this forum clean from such offtopic infos.