[Approved] Unicode file names for recordings (1 Viewer)

[mm1352000]

For testers that would find it useful to have binaries, here you go

 

[Vasilich]

mm, how the second set suppose to work if the argument type differs from those calling by unmodified TVLibrary?

proof: https://forum.team-mediaportal.com/...rungraph-returns-0x800705aa-88819/index4.html

 

[mm1352000]

Hi Vasilich. Sorry you are absolutely correct
Too early in the morning where I am.
I will withdraw the second version and recompile for god_md5.

 

[mm1352000]

I reiterate my apology to Vasilich :sorry:
Thank you for your work. It is only my binary-building that was at fault

Since I have already made a binaries for 1.1.1 I figured I would make binaries for 1.1.2 as well. Here they are...

 

[Vasilich]

anyone for approving this before 1.2 beta releases?

 

[chemelli]

Guys, how is the status ? I asked Vasilich to remove all attachments and post the latest version on first post to avoid confusion.

Simone

 

[mm1352000]

Hi Simone

In my opinion the patch code is okay although it is a little hard to clearly see the functional changes since there seem to be a lot of whitespace changes. This is picky, but I'm not really a fan of the 'W' on the end of all the function names - I don't think there is any need for changes in the internal workings of functions to affect their names unless the functionality has radically changed. That aside, the patch seems to be effective. I will patch my system tonight and confirm that nothing is broken for me. Assuming that everything is okay I'd happily recommend this for inclusion in 1.2.0b.

 

[arion_p]

I was about to commit this patch in SVN last night, when I realized that it only solves part of the problem. Making TsWriter/MPFileWriter Unicode aware, allows recordings to have Unicode characters in their file names. But these recordings will never play within MP, since neither TsReader nor StreamingServer support Unicode file names. Patching TsReader and StreamingServer to support Unicode is not trivial, so I am not sure if Vasilich can have them ready in time for 1.2.0beta.

I should have realized this earlier, :sorry:

 

[Vasilich]

thanks to pointing me on , arion.
I checked it briefly and it seems that only streaming server is the problem. As i use singleseat - my tests were successful because TSReader is able to read unicode filenames.
I will try to fix streaming server handling ASAP (i.e. tonight/tomorrow) (it seems that there is only one file to correct - StreamFileSource. FileReader already handles unicode).

 

[Vasilich]

Me again. Finally got possibility to test TV on my dev machine.
So in attach is the patch for all parts of tv - tswriter, reader, streaming server... for latest trunk. Works for me both in single-seat (UNC) and multiseat (RTSP) modes.