Reply to thread

Message

<blockquote data-quote="morpheus_xx" data-source="post: 1154099" data-attributes="member: 48495">[USER=119106]@henso[/USER]&nbsp; and&nbsp; [USER=106003]@FreakyJ[/USER] , nice to see the good progress on this plugin <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite24" alt="(y)" title="Thumbs Up&nbsp; &nbsp; (y)" loading="lazy" data-shortname="(y)" />.I have some ideas regarding the many &quot;if / else&quot; code blocks for constructing ffmpeg arguments. One example: <a href="https://github.com/MediaPortal/MediaPortal-2/blob/FEAT_DLNAv4/MediaPortal/Incubator/TranscodingService/Transcoders/FFMpeg/FFMpegCommandline.cs#L426-L441" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/FEAT_DLNAv4/MediaPortal/Incubator/TranscodingService/Transcoders/FFMpeg/FFMpegCommandline.cs#L426-L441</a>, where there are too many checks.I'd suppose to reduce the lines of code and putting more configuration options into dictionaries like:[CODE=CSHARP]&nbsp; Dictionary&lt;EncodingPreset, string&gt; SWEncodingPresets = new Dictionary&lt;EncodingPreset, string&gt;&nbsp; {&nbsp; { EncodingPreset.Ultrafast, &quot;-preset ultrafast&quot; },&nbsp; { EncodingPreset.Superfast, &quot;-preset superfast&quot; }&nbsp; };&nbsp; Dictionary&lt;EncodingPreset, string&gt; IntelEncodingPresets = new Dictionary&lt;EncodingPreset, string&gt;&nbsp; {&nbsp; { EncodingPreset.Ultrafast, &quot;-preset ultrafast&quot; },&nbsp; { EncodingPreset.Superfast, &quot;-preset superfast&quot; }&nbsp; };&nbsp; Dictionary&lt;EncodingPreset, string&gt; NVidiaEncodingPresets = new Dictionary&lt;EncodingPreset, string&gt;&nbsp; {&nbsp; { EncodingPreset.Ultrafast, &quot;-preset ultrafast&quot; },&nbsp; { EncodingPreset.Superfast, &quot;-preset superfast&quot; }&nbsp; };[/CODE]Then you have choose the matching dict only once and use a .TryGet() to translate the presets to string args in one line. If you apply this to the other arguments as well, the number of code lines will be significantly reduced. It would also allow moving out the mappings into settings, what would allow easier extension without adding more code lines.I have not checked other parts, but I hope you can apply some of those refactorings <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /></blockquote>

[QUOTE="morpheus_xx, post: 1154099, member: 48495"] [USER=119106]@henso[/USER] and [USER=106003]@FreakyJ[/USER] , nice to see the good progress on this plugin (y). I have some ideas regarding the many "if / else" code blocks for constructing ffmpeg arguments. One example: [URL]https://github.com/MediaPortal/MediaPortal-2/blob/FEAT_DLNAv4/MediaPortal/Incubator/TranscodingService/Transcoders/FFMpeg/FFMpegCommandline.cs#L426-L441[/URL], where there are too many checks. I'd suppose to reduce the lines of code and putting more configuration options into dictionaries like: [CODE=CSHARP] Dictionary<EncodingPreset, string> SWEncodingPresets = new Dictionary<EncodingPreset, string> { { EncodingPreset.Ultrafast, "-preset ultrafast" }, { EncodingPreset.Superfast, "-preset superfast" } }; Dictionary<EncodingPreset, string> IntelEncodingPresets = new Dictionary<EncodingPreset, string> { { EncodingPreset.Ultrafast, "-preset ultrafast" }, { EncodingPreset.Superfast, "-preset superfast" } }; Dictionary<EncodingPreset, string> NVidiaEncodingPresets = new Dictionary<EncodingPreset, string> { { EncodingPreset.Ultrafast, "-preset ultrafast" }, { EncodingPreset.Superfast, "-preset superfast" } }; [/CODE] Then you have choose the matching dict only once and use a .TryGet() to translate the presets to string args in one line. If you apply this to the other arguments as well, the number of code lines will be significantly reduced. It would also allow moving out the mappings into settings, what would allow easier extension without adding more code lines. I have not checked other parts, but I hope you can apply some of those refactorings :) [/QUOTE]

Verification