Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1192702" data-attributes="member: 82144">Yes that hypothesis is correct... and the reason is as you previously described: unbalanced treatment of the radio and TV sections.Not at all. How else would you easily delete watched recordings?Yes, as above.No I don't think it's a bug. Confused yet? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />First, the user-initiated clean up function in both TV and radio has existed for a long time. It wasn't added when the automatic cleanup function was &quot;removed&quot;.Automatic cleanup was disabled for TV to appease people that keep recordings on NAS that is not always online. What would happen is that when they entered recording sections with their NAS offline, TV Server would not be able to find their recording files and so would automatically delete the recordings from the database.In my opinion the &quot;fix&quot; that was applied is awful. It's inconsistent between TV and radio as you've seen. I also think it's poorly thought out. A more appropriate fix would've been to simply check if the NAS/share is online before proceeding. If it is, fine and carry on; if not, don't proceed. That would have satisfied both the NAS owners and the folks who complained that invalid - usually deleted manually via Windows Explorer, or moved due to post-processing - recordings were no longer being cleaned up for them automatically.[edit: In case it wasn't clear, I think the fix applied to the TV section is a bug. It ought to be rolled back and dealt with properly for both radio and TV.]&lt;sigh&gt;Anyhow as you know TV Server is under code freeze, so in the short term I don't foresee any code changes in TVE 3 to improve the situation. From I TVE 3.5 perspective, thanks to Andy I've ensured that the thumbnailer won't attempt to create thumbnails for radio recordings. That was a one-liner. I currently don't have the &quot;bandwidth&quot; to deal with the other things discussed above.</blockquote>

[QUOTE="mm1352000, post: 1192702, member: 82144"] Yes that hypothesis is correct... and the reason is as you previously described: unbalanced treatment of the radio and TV sections. Not at all. How else would you easily delete watched recordings? Yes, as above. No I don't think it's a bug. Confused yet? :D First, the user-initiated clean up function in both TV and radio has existed for a long time. It wasn't added when the automatic cleanup function was "removed". Automatic cleanup was disabled for TV to appease people that keep recordings on NAS that is not always online. What would happen is that when they entered recording sections with their NAS offline, TV Server would not be able to find their recording files and so would automatically delete the recordings from the database. In my opinion the "fix" that was applied is awful. It's inconsistent between TV and radio as you've seen. I also think it's poorly thought out. A more appropriate fix would've been to simply check if the NAS/share is online before proceeding. If it is, fine and carry on; if not, don't proceed. That would have satisfied both the NAS owners and the folks who complained that invalid - usually deleted manually via Windows Explorer, or moved due to post-processing - recordings were no longer being cleaned up for them automatically. [edit: In case it wasn't clear, I think the fix applied to the TV section is a bug. It ought to be rolled back and dealt with properly for both radio and TV.] <sigh> Anyhow as you know TV Server is under code freeze, so in the short term I don't foresee any code changes in TVE 3 to improve the situation. From I TVE 3.5 perspective, thanks to Andy I've ensured that the thumbnailer won't attempt to create thumbnails for radio recordings. That was a one-liner. I currently don't have the "bandwidth" to deal with the other things discussed above. [/QUOTE]

Verification