[Bug] Video player not closed / stopped correctly when an error occured (1 Viewer)

[chefkoch]

When an error occured the video player is not stopped correctly. At first the fullscreen workflow state is not left and after pressing ESC the background image is not displayed, but a black background instead. See screenshot.

I am not sure if it is a OnlineVideos fault or an MP2 client issue.
Steps to reproduce:

• Start a video in onlinevideos plugin
• disable wifi at your notebook or cut the connection from your router to your provider

 

[morpheus_xx]

Should be fixed in [15:41] <MP2-GitBot> [MediaPortal-2] morpheusxx created FIX_ClosePlayerSlotOnError (+1 new commit): http://git.io/M0FCng

 

[chefkoch]

It's weird: Video plays until end of cached stream of course.

Once this is reached sometimes it simply waits > frozen picture but nothing happens (MP2 and GUI is not frozen), once I enable the wifi connection again it continues playback. --> OK, no problem.

Another try and it stopped playback again automatically, now the video play seems to be release properly, but the GUI does not show up automatically:

When moving the mouse I get the video osd:

So it seems the player context / player manager is not updated properly or anything similar.

Pressing Stop does do anything.

Pressing Back brings back the GUI:



EDIT: Addtionally when closing MP2-Client.exe, the window is gone, but the exe is still running in the background, have to close it via taskmanager.

 

[morpheus_xx]

My change should not affect this behavior, it only cares for the building of players. I think what you describe is another issue, I.e. that the graph could not be stopped and freed correctly.