Visualization Fixed for 1.7 Final (1 Viewer)

B

BassFan

Guest
none of the Developer wanted to add my changes to 1.7 Final
therefore I have created here own test build for you.

MP1-4391-BUG Memory leak in bass_vis
MP1-4379-BUG Flickering visualization when switching sections (Visualization now always invisible if not in FullScreen Mode)
MP1-4428-BUG Mediaportal and Configuration crash if BassBox visualization installed only.

Fixed some errors with NULL pointer
Remove INIT Flags for BassBox and Sonique, previous run of the plugin over BASSVIS_EXEC is no longer necessary.
BassBox Plugins were not correctly free.
changed BassVisAPI and BassVis to vers. 2.4.4.0

create from the last master branch to.

greets
 
Last edited by a moderator:

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Thanks :)
    Happy to see that you do fix for WMP, it was waiting for MP1-4379 :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    It seems we don't have branch for MP1-4391.
    MP1-4379 is not up to date.

    So Testers can't really test and then other can't review the code -> this is why not included.

    @BassFan can you post patch too ? :)
    Thanks :)
     
    B

    BassFan

    Guest
    i can that Problem which i have..
    i post patch, Patch and Patch again and nothing is add to current release.
    why i'm work and all my patches ignored?


    greets
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    For sure, it seems that i missed it lol.
    You can't have access to Jira ? (better to put patch there to not forget it) like right now i'm busy but i'm not the only one too lol.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hi,

    Could you create a patch for each branch ?
    Your patch (Viz.patch) can be apply on master :p but we need to separate it for each branch and i'm not sure what i need to take from the patch file for that (like all is mixed) :)

    Thanks :)
     

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,475
    4,645
    49
    ::1
    Home Country
    Netherlands Netherlands
    MP1-4391-BUG Memory leak in bass_vis
    This 1 is already merged to master, and is included in the 1.7 Final build ;)

    MP1-4428 is fine, so we can include that in an upcoming release (or hotfix!)

    MP1-4379 is almost fine. @BassFan as Sebastiii suggested, can you please post the patch for the WMP issue only? then we can include that in the branch for the next release ;)
     
    B

    BassFan

    Guest
    @Sebastiii like all is mixed
    yes ... no idea i can do it without write all my changed again..

    @BassFan MP1-4428 is fine, so we can include that in an upcoming release (or hotfix!)


    to late!
    I changed the last Load routine of plugins
    Therefore, this patch is no longer necessary

    all the plugin kind used now
    Code:
    _visParam.VisHandle = BassVis.BASSVIS_GetModuleHandle(BASSVISKind.BASSVISKIND.Bla_Bla, filePath);
    execute of any Plugin for retrieve a Module-Handle is no longer necessary
    so get pluginname and pluginmodulename is any faster.

    greets
     
    Last edited by a moderator:

    Users who are viewing this thread

    Top Bottom