1.32 Windows 11 support (1 Viewer)

[framug]

Even if MP is working on Windows 11, both, SetupTV, TvService, MP config and MP client doesn't give the correct Windows 11 OS version running, in logs.
The provided OSInfo class fix that.

Before :

[2023-07-29 10:55:38,781] [Log    ] [SetupTv  ] [INFO ] - ---- SetupTv v1.31.100.0 is starting up on Windows 10 Professional x64 [10.0.22621.0]

After :

[2023-07-29 10:57:40,161] [Log    ] [SetupTv  ] [INFO ] - ---- SetupTv v1.31.100.0 is starting up on Windows 11 Professional x64 [10.0.22621.0]

 

[ajs]

MediaPortal-1/Common-MP-TVE3/OsInfo/OSInfo.cs at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

MediaPortal-1/Common-MP-TVE3/OsInfo/OSInfo.cs at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

 

[framug]

MediaPortal-1/Common-MP-TVE3/OsInfo/OSInfo.cs at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

MediaPortal-1/Common-MP-TVE3/OsInfo/OSInfo.cs at master · MediaPortal/MediaPortal-1

Home Theater and Digital Video Recording solution for Windows. - MediaPortal/MediaPortal-1

github.com

And then ?
Where is Windows 11 ?
Nowhere !

That's why, according to this :

Before :

      if (
        !IsOSAsReported(OSMajorVersion, OSMinorVersion, OSBuildVersion, (byte) OSProductType, (short) OSServicePackMajor))
        osName = "Compatibilty Mode: " + osName;

After :

      if (!IsOSAsReported(OSMajorVersion, OSMinorVersion, OSBuildVersion, (byte) OSProductType, (short) OSServicePackMajor))
      {
        osName = "Compatibilty Mode: " + osName;
      }

      if (osName == "Windows 10" && OSBuildVersion >= 22000)
      {
        osName = "Windows 11";
      }

 

[ajs]

And then ?

Because it must be done in those two places, and not where you did.

 

[ajs]

Where is Windows 11 ?

Where Server 2019? Where Server 2022?

 

[framug]

Because it must be done in those two places, and not where you did.

Not the first link you pointed.
Tomorrow, M$soft decide, with another Windows update, that Windows 11 is not a 0 (zero) OsMinor, code will not work.

 

[ajs]

Windows Version Numbers - Tech Thoughts

Quickly reference windows version numbers for both client and sever Microsoft Operating systems. PowerShell example provided to get your OS version number

www.techthoughts.info

 

[framug]

Where Server 2019? Where Server 2022?

Please, note the title of this thread, "Windows 11 support".
Do what you want, I can't give you more than on the first post, my change is working for Windows 11....

 

[ajs]

If you make changes, then do them correctly, we have two 2 functions that give information about the operating system, you made changes in one, and then a crutch. And we will get that one function will return Windows 10, the second 11, on the same Operating system. In my opinion, this is not correct.
Well, if you change it, then you must immediately add the current versions of the Server, the information is available, you just need to make changes.

 

[framug]

If you make changes, then do them correctly, we have two 2 functions that give information about the operating system, you made changes in one, and then a crutch. And we will get that one function will return Windows 10, the second 11, on the same Operating system. In my opinion, this is not correct.
Well, if you change it, then you must immediately add the current versions of the Server, the information is available, you just need to make changes.

The OSProductType has not been changed by Msoft, it continue to be 10, at least for win 11.
And the method GetOSName() is never used.

The used method in MP is GetOSNameString(), for displaying OS informations.
That's why, changes are there...