1.32 Windows 11 support (2 Viewers)

[ajs]

Well, I think that we need to do it right away and correctly, and close all current options. But you made the changes as you see fit, create a Pull Request, we will make them in the next release.

 

[framug]

As already discussed in internal, will not do pull or something else...
You think that finally, it's a good thing for users then please, add it to the code (replace class by modified one), to finally go in master.
That's all, as simple as that !

 

[ajs]

I can't add such code under my name, sorry.

 

[ajs]

I can offer you this option.

 

[framug]

I can offer you this option.

Hello,

Well, it seems you added Windows 2022 server, more than Win 11.
Let's say why not, ?
Even if I don't think MP is often used with Windows Server OSes, let's say it's OK for me.
I just would like you understand, it's not an offer.
If you disagree with what I propose, I can understand but finally, it won't keep me awake at night and, I will be alone to use the improvment I propose, finally this will not be nice for all others users.
Reject because not all OSes has been implemented (or others things like that, depending on cases), is not really correct and, can hurt, sometimes.
Then, simply push that and go ahead !!

 

[ajs]

Even if I don't think MP is often used with Windows Server OSes, let's say it's OK for me.

I use.

Reject because not all OSes has been implemented (or others things like that, depending on cases), is not really correct and, can hurt, sometimes.

I didn't reject anything, I don't like the look of your changes, so I don't want to post them under my name. Therefore, I suggested that you make them under yours, but you do not want this either.
Compare your version, and this one (only applies to Windows 11).

            case 10:
            {
              switch (OSMinorVersion)
              {
                case 0:
                  if (OSProductType == NTProductType.NT_WORKSTATION)
                  {
                    if (OSBuildVersion < 22000)
                      osName = "Windows 10";
                    else
                      osName = "Windows 11";
                  }
                  break;
              }
              break;
            }

 

[framug]

See my previous post you found funny....
Tomorrow, Win 11 22Hxx or 23Hxx, blabla... is not OSMinorVersion = 0, your code will not work...
But, we will be able to change that, if any.
Mine worked (may be) more time without changes than your....

 

[ajs]

Tomorrow, Win 11 22Hxx or 23Hxx, blabla... is not OSMinorVersion = 0, your code will not work...

It will work, because there will always be 0, except that in Windows 12 it can theoretically change if the platform changes.

 

[framug]

Msoft

It will work, because there will always be 0, except that in Windows 12 it can theoretically change if the platform changes.

May be you are working for Msoft and you have such informations ?
It's not my case...
And more since GetVersion() has been deprecated....