[Pending] XMLTVImport - fix import from http://xmltv.xmltv.se/ (1 Viewer)

hkjensen

MP Donator
  • Premium Supporter
  • June 11, 2007
    164
    65
    Copenhagen
    Denmark Denmark
    Country flag
    Hi

    TV guide data from xmltv.xmltv.se contains <episode-num system="thetvdb.com"></episode-num> witch can't be processed by the plugin resulting in zero program are imported :-(

    With attached patch to TvEngine3/TVLibrary/Plugins/XmlTvImport/XMLTVImport.cs the plugin only reads episodenum with system equals "xmltv_ns" or "onscreen"
     

    Attachments

    mm1352000

    Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    Hello :)

    Thank you for the patch. Unfortunately I think we have to reject it. Some people are getting episode numbers from systems other than xmltv_ns and onscreen. If we accepted this patch those people would lose their episode numbers.

    Maybe a better way would be to enable the code to skip/ignore or handle the empty tvdb episode-num tags.
     

    Peter Kjellerstedt

    Portal Member
    January 12, 2013
    7
    1
    47
    Lund, Sweden
    Sweden Sweden
    This definitely needs to be fixed, one way or another. I have been using a similar solution (attached). If it finds an xmltv_ns episode number, it will prioritize and use that, otherwise it will use the first episode number it finds as before.

    And for the record, the thetvdb.com episode numbers are not empty in the xml file, they are just not usable with MediaPortal...
     

    Attachments

    mm1352000

    Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    And for the record, the thetvdb.com episode numbers are not empty in the xml file, they are just not usable with MediaPortal...
    Can you please supply a full <programme> example which includes a non-empty thetvdb.com episode number?
     

    Peter Kjellerstedt

    Portal Member
    January 12, 2013
    7
    1
    47
    Lund, Sweden
    Sweden Sweden
    And for the record, the thetvdb.com episode numbers are not empty in the xml file, they are just not usable with MediaPortal...
    Can you please supply a full <programme> example which includes a non-empty thetvdb.com episode number?
    This is a typical entry:

    Code:
    <programme channel="animalplanet.discovery.eu" start="20160604040200 +0200" stop="20160604044900 +0200">
      <category lang="en">Reality</category>
      <category lang="en">series</category>
      <date>2013</date>
      <desc lang="en">A silver maple is used as the base for a cedar-shingled structure with a curved turret two stories high and a deck with views of Lake Chelan.</desc>
      <episode-num system="onscreen">Episode 3 season 4</episode-num>
      <episode-num system="thetvdb.com">series/270071</episode-num>
      <episode-num system="xmltv_ns">3 . 2 .</episode-num>
      <sub-title lang="en">Mindbending Silver Maple</sub-title>
      <title lang="en">Treehouse Masters</title>
      <url>http://thetvdb.com/?tab=episode&amp;seriesid=270071&amp;seasonid=627205&amp;id=5277168&amp;lid=7</url>
    </programme>
    I think the best would be to give the various episode systems priorities based on what is most useful for MediaPortal, e.g., xmltv_ns > onscreen > anything else. My patch prioritizes only xmltv_ns since I know my data always contains it somewhere, but the patch could easily be extended to also give priorities to other systems, like onscreen.
     

    mm1352000

    Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    This is a typical entry...
    Thanks. :)
    The TVDB page for the corresponding series is:
    http://thetvdb.com/index.php?tab=series&id=270071&lid=7

    So, it looks like that particular format conveys the series ID. That can be useful for meta-data lookup and obtaining the actual season and episode details.

    Do you have any examples where the first part is not "series/"?

    I think the best would be to give the various episode systems priorities based on what is most useful for MediaPortal, e.g., xmltv_ns > onscreen > anything else. My patch prioritizes only xmltv_ns...
    I agree, and that's why I wouldn't be in favour of including your current patch.
     

    Peter Kjellerstedt

    Portal Member
    January 12, 2013
    7
    1
    47
    Lund, Sweden
    Sweden Sweden
    Thanks. :)
    The TVDB page for the corresponding series is:
    http://thetvdb.com/index.php?tab=series&id=270071&lid=7

    So, it looks like that particular format conveys the series ID. That can be useful for meta-data lookup and obtaining the actual season and episode details.
    Well, the actual URL to the thetvdb.com page for the episode is in the <url> tag. However, I am not sure how useful it would be to try to do a lookup based on only what is in the <episode-num> tag for thetvdb.com, as it only contains the series id, and nothing about the actual season and episode.

    Do you have any examples where the first part is not "series/"?
    No. The XML data from http://xmltv.xmltv.se/ only contains that format for thetvdb.com <episode-num> tags.

    I think the best would be to give the various episode systems priorities based on what is most useful for MediaPortal, e.g., xmltv_ns > onscreen > anything else. My patch prioritizes only xmltv_ns...
    I agree, and that's why I wouldn't be in favour of including your current patch.
    I can extend the patch to handle onscreen in addition to xmltv_ns. Are there other episode-num formats that MediaPortal can actually make use of? Otherwise, that should be enough to make better use of the input data while still maintaining the old functionality.
     

    hkjensen

    MP Donator
  • Premium Supporter
  • June 11, 2007
    164
    65
    Copenhagen
    Denmark Denmark
    Country flag
    Hi

    I have created a new patch, where system for episodenum can be selected, if no selected is made, episodenum is read from first available episodenum element (current behavior)

    I have attache a screen dump of setup (plugin->XmlTv)

    Definitions of imports:
    - first: Load epsioden umber from first element (current behavior and default selection)
    - onscreen: Load episode number from element with system="onscreen"
    - xmltv_ns: Load episode number from element with system="xmltv_ns"
    - not defined: load episode number from element with system not defined ex: <episode-num>episode 1 of 2 </episode-num>
    if episode number is not found for "onscreen","xmltv_ns" or "not defined" first element is used

    If the described functionality can be accepted I will submit the patch (currently testing)
     

    Attachments

    Last edited:

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    W XMLTVImport duplicate item error xmlTV 5
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    framug [Approved] Fix Irtrans config bug Submit: code patches (MediaPortal/TV-Server/etc.) 4
    W [solved] [FIXED] Survivor season 40 not automatically matching My TVSeries 1
    P [solved] ATSC subtitles not fixed yet? General 2
    framug [Rejected] Fix PowerScheduler plugin for MP2 single seat Submit: Code Patches 9
    M [Pending] Fix for Inconsistent date display in TV Guide Submit: code patches (MediaPortal/TV-Server/etc.) 1
    doskabouter [Proposal] Merge PR Fix for source directory with spaces MediaPortal 1 15
    CyberSimian Fixes for Amped aMPed 5
    CyberSimian Fixes for Amped skin MediaPortal 1 10
    L TV-Series unvollständiger Import Plugins & Erweiterungen 5
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    Lichloathe MP2 importing keyart instead of poster General 0
    P Recordings not showing up unless re-imported and not possible to delete General 0
    C Importer works super slow My TVSeries 5
    C Imported media doesn't show up immediately? General 1
    X Recording import hängt Allgemeines Support- und Diskussionsforum 0
    J [fixed] Import issue with alternate movie title matching the name of another movie Submit: Bug Reports 7
    B xmltv - cannot import tvguide.xml australia Installation, configuration support 0
    B [solved] tvguide.xml not importing australian channels Electronic Program Guide 10
    J [fixed] Importer confused on specific movies with the same title, different years and different NFO's Submit: Bug Reports 3
    azzuro [fixed] [WIP MP2.3] - Audio files not imported to MP MediaPortal 2 18
    thepahakurki TVDB import not working My TVSeries 3
    T I cannot get a basic media import-what is the best configuration? General 10
    L TV-Series kein Import Plugins & Erweiterungen 6
    Similar threads

























    Top Bottom