Hauppauge HD-PVR & Colossus Support (2 Viewers)

[WileECoyote]

Hey mm1352000,
The attached files are my mods on your latest patches to add Colossus support. There is only one change to the TVCardCollection.cs file, and the Locals & Constructors of the TVCardHDPVR.cs & HDPVRChannel.cs files. You can do a diff against your latest to find the changes. These changes are minimal and do not impact the HDPVR or any other code.

Thanks!
Wile E.

P.S. I recieved my second Colossus tuner today, so I also modded the code for multiple tuners.

 

[mm1352000]

Arg! The power of one line of code...

:sorry:

 

[WileECoyote]

Arg! The power of one line of code...

:sorry:

I hope you didnt misunderstand my post, the code attached to the prior post is for the Colossus changes only. I havent figured out the issue with the channel change

If you need more info (Logs, etc) please let me know.

Thanks!

 

[mm1352000]

Eeeek! :sorry::sorry::sorry:

I forgot the attachment. You must have thought I was moaning about your changes. I *sincerely* apologise! What I meant was that *I* missed one line of code, and that is what was wrong with the last build.

Apologies once again....

BTW: I'm putting together a patch with the Colossus support included. I just clean ran out of time though this morning. I have to get to work now - I'm already late

 

[WileECoyote]

Eeeek! :sorry::sorry::sorry:

I forgot the attachment. You must have thought I was moaning about your changes. I *sincerely* apologise! What I meant was that *I* missed one line of code, and that is what was wrong with the last build.

Apologies once again....

BTW: I'm putting together a patch with the Colossus support included. I just clean ran out of time though this morning. I have to get to work now - I'm already late

No worries, Thanks!

BTW, what was the one line of code? I only ask so I can do more testing with dual Colossus tuners tonight

 

[mm1352000]

The one line was:

      if (!SetupPmtGrabber(HDPVR_PMT_PID, HDPVR_SERVICE_ID))
      {
        // Already "tuned" and receiving PMT. Set the
        // PMT version to trick the timeshifting logic
        // into thinking that we waited and received PMT,
        // and then reset the audio/video events so that
        // the timeshifter can detect audio and video.
        _pmtVersion = 0;
        [B]OnAfterTuneEvent();[/B]
        return true;
      }

 

[WileECoyote]

Arg! The power of one line of code...

:sorry:

Unfortunately the same result. First tune works fine, but changing the channel gives error...

Logs attached.

As far as the Colossus integration goes, please look at my code I attached on post #51. You should quickly be able to see what I have done and drop my code right it. I can pull out the code I added if you would like.

Thanks!

 

[elliottmc]

Hi,

Would it be possible for someone to clarify?

Does the HDPVR work in MediaPortal 1.2.0alpha?

Also, I guess (but remember I don't make the decision) the Colossus support will not be included in 1.2.0beta, as this is a new feature.

Best wishes,

Mark

 

[mm1352000]

Hi Mark

Does the HDPVR work in MediaPortal 1.2.0alpha?

I believe it does, yes.

Also, I guess (but remember I don't make the decision) the Colossus support will not be included in 1.2.0beta, as this is a new feature.

That is something that I think should be seriously discussed. I'd be leaning towards including it...

 

[mm1352000]

Okay Wile E

I've removed the code that doesn't wait for PMT on retune - I possibly could have fixed it, but it seems to only be causing trouble. I've also incorportated your Colossus code D) with a few minor modifications (like logging -> "HDPVR:..." or "Colossus:...", which just makes things a little nicer). The final thing that I've done is to include more thorough quality control support. I'm not sure if the HD PVR or Colossus support that, but code support was partially there so it either needed to be completed or taken out entirely. Patch and binary attached...