[fixed] 1.2 Beta Coverflow Bug? (1 Viewer)

jameson_uk

Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    Yes it's a bug. Both Filmstrip and CoverFlow didn't implement one of the facade methods for setting focus. They however had implementation for focus on GUI message. So depending on the plugin code, focus was set correctly for some plugins and not for others.

    I've fixed it. Any mantis?

    Not sure what you are seeing here as I think that is a different bug...

    In music only code I can see for filmstrip is
    Code:
          GUIFilmstripControl filmstrip = parent as GUIFilmstripControl;
          if (filmstrip == null)
          {
            return;
          }
    
          if (item.Label == "..")
          {
            filmstrip.InfoImageFileName = string.Empty;
            return;
          }
          else
          {
            filmstrip.InfoImageFileName = item.ThumbnailImage;
          }
    Which I don't see would do anything with selection (in fact this is only called after an item has been selected)

    But if I go into filmstrip in music and press backspace on keyboard nothing happens (as expected). If I go to cover flow and press backspace on keyboard it jumps to item 1.

    I am struggling to see that what you are describing fixes the issue.... how does pressing backspace trigger a change of item?

    I will raise a Mantis if you have fixed but not sure what is actually the bug here
     

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Home Country
    Croatia Croatia
    Hi jameson_uk,

    I have discovered and fixed both bugs (missing focus methods and backspace key in CoverFlow) :)
     

    Attachments

    • !!!SE - focus v01.patch
      4.4 KB

    h4rd

    Portal Member
    October 29, 2008
    24
    0
    Hamburg
    AW: 1.2 Beta Coverflow Bug?

    great!!! thank you :D

    is there a chance to fix the problem in my current installation ??

    mfG
    Björn
     

    Users who are viewing this thread

    Top Bottom