1.4.0 Pre Subtitle paths not respected 100% with UNC (1 Viewer)

pellegj

Portal Pro
May 7, 2009
106
32
Home Country
Sweden Sweden
Just found what i suspect is kind of a bug.
I have all my media-files on a NAS and use UNC-paths to access them. I'm in the works of rearranging my library and found a problem with subtitle-paths, at least for me it's a problem. I had planned to put my subtitles in a different share from the movies. like the following:
\\SERVER\Movies\SUBFOLDER\SUBFOLDER\Moviefolder
\\SERVER\Subtitles
When I then input my subtitle path into MP config and play a movie it wont use any subtitle. However if i map \\SERVER\Subtitles to, lets say S:\ and change config in MP to reflect the mapped drive and play the movie it will find the subtitles and display them as supposed to.
 

kiwijunglist

Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    Interesting idea, I've never thought of storing subtitles remotely from movies before. I could see numerous disadvantages, mainly that when you delete a movie it takes longer to delete the associated subtitle and some mediaplayers +/- mpextended won't pick up on the subtitle.

    Q: Are there any additional advantages to doing it this way apart from having a slightly tidier media folder?
     

    pellegj

    Portal Pro
    May 7, 2009
    106
    32
    Home Country
    Sweden Sweden
    Interesting idea, I've never thought of storing subtitles remotely from movies before. I could see numerous disadvantages, mainly that when you delete a movie it takes longer to delete the associated subtitle and some mediaplayers +/- mpextended won't pick up on the subtitle.

    Q: Are there any additional advantages to doing it this way apart from having a slightly tidier media folder?
    Yes. I can put in the movies, and anyone can put in the subs. This way i can have read access on the movie folder and read/write on the subs. Hence, I'm the only person that can delete movies. If someone by mistake deletes a subtitle is one thing, but a movie is another problem.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hi :)

    I have found why, it's on C++ code, it replace '\\' to '/' but i'm not a c++ guru lol.
    But i will try something :)
     

    pellegj

    Portal Pro
    May 7, 2009
    106
    32
    Home Country
    Sweden Sweden
    I downloaded the source code, but i have no idea where to begin looking for the file where the replacement takes place.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Look for : GFN.cpp in DirectShowFilters\mpc-hc_subs\src\subtitles

    The culprit is here :
    Code:
    		for (size_t k = 0; k < paths.GetCount(); k++) {
    			CString path = paths[k];
    			path.Replace('\\', '/');

    If i bypass : path.Replace('\\', '/'); <<<--- It's OK :)
     

    Users who are viewing this thread

    Top Bottom