1.4.0 Pre Subtitle paths not respected 100% with UNC (2 Viewers)

[pellegj]

Look for : GFN.cpp in DirectShowFilters\mpc-hc_subs\src\subtitles

The culprit is here :

		for (size_t k = 0; k < paths.GetCount(); k++) {
			CString path = paths[k];
			path.Replace('\\', '/');

If i bypass : path.Replace('\\', '/'); <<<--- It's OK

The question is why the replace is being made in the first place.
I'm not in any way used to c++, but if I'm understanding it correctly it should get replaced back again 12 lines down in the code.

 

[Sebastiii]

I don't know

And it seems that this is not needed (maybe usefull for linux path system ?)

 

[pellegj]

I don't know

And it seems that this is not needed (maybe usefull for linux path system ?)

That was my thought also, but since MPC-HC is not available for Linux it's hard to say. But then again, they could have borrowed the code from some other project. But as you say, it should not be needed for a Windows only application as far as i know.

EDIT:
I should also mention that i have not tested this in any previous MP version.

 

[pellegj]

A little update.
I tested in MPC-HC stand alone, and as i suspected it's the same problem there.
So this is not actually an MP thing.

 

[Sebastiii]

I have comment out that line and right now didn't see regression but not sure if it's a safe fix lol

 

[Sebastiii]

Hi,

Bump this, i use for a while now (and i use sub lol) and seems no regression

 

[Holzi]

Do we have a Jira entry (and branch)?

 

[Sebastiii]

I'm not sure

 

[pellegj]

I went another way. I use Directory links in NTFS instead. So now i have linked subdirectory named C:\Subs which infact is \\SRV\Subtitles. With this way i can still use the official builds of MP and still have subs the way i want to.