[TV] [solved] 4994: Automatically Change Channel on Program Reminder (1 Viewer)

vapourEyes

Portal Pro
July 31, 2013
138
41
United Kingdom United Kingdom
Country flag
Hi there, I am getting build errors on Master.

Showing this code:
using System;
using MediaPortal.GUI.Library;
using MediaPortal.Dialogs;
using TvDatabase;
using Common.GUIPlugins;
using Action = MediaPortal.GUI.Library.Action;

namespace TvPlugin
{
public abstract class RecordedBase : WindowPluginBase
{

Error 7 The type or namespace name 'GUI' does not exist in the namespace 'MediaPortal' (are you missing an assembly reference?) MediaPortal-1-master\TvEngine3\TVLibrary\TvPlugin\TvPlugin\RecordedBase.cs 2 19 TvPlugin
 

regeszter

Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Hungary Hungary
    Can someone apply this patch?

    git.exe am --3way --ignore-space-change --keep-cr "Z:\R\MediaPortal-1-master.patch"
    Patch format detection failed.

    Fail
     

    vapourEyes

    Portal Pro
    July 31, 2013
    138
    41
    United Kingdom United Kingdom
    Country flag
    The patch was cut at the \TvEngine3\TVLibrary\TvPlugin\TvPlugin level.
    This was to prevent artifacts at other parts of the tree from taking part in the patch.

    I hope that is ok. If not I can cut another one at the top level ?
     

    vapourEyes

    Portal Pro
    July 31, 2013
    138
    41
    United Kingdom United Kingdom
    Country flag
    Thank you... will do so shortly.
    --- Post updated ---
    Sorry about this. I have not used GIT for some time, as is becoming obvious :unsure:

    1. Pull origin/master - done.
    2. Create a new branch - done.
    3. Make your code changes - done.
    4. Commit your changes - done - but if i commit these changes, it seems I can no longer create a patch ??? ***
    5. Creating a Patch Serial
    *** - I have tried this with both Tortoise GIT and Eclipse GIT.
    It seems I have to make changes, possibly on a new branch, and then create a patch for that ?
    --- Post updated ---
    Submit patch, the sequel....
     

    Attachments

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Hungary Hungary
    What does it mean? ;)

    Code:
                //if (TVHome._playNotifyBeep)
                {
                  MediaPortal.Util.Utils.PlaySound("notify.wav", false, true);
     

    vapourEyes

    Portal Pro
    July 31, 2013
    138
    41
    United Kingdom United Kingdom
    Country flag
    Hi regeszter,

    I have to comment that line, to get the sound notification to work.
    I think, now, that NotifyChannelChange(), should be hosted within TvHome. If it was located within TvHome, the comment would not be needed.
    That method was based on another method, OnGlobalMessage(), within TvHome.

    Its closely based on the section of code following:
    case GUIMessage.MessageType.GUI_MSG_NOTIFY_TV_PROGRAM:

    Have you any thoughts on this ?

    *** the eclipse GIT tooling does not support Creating a Patch Serial, that I can see.
    You have to use Tortoise GIT to get the 'Create a Patch Serial' option.

    That explains why I got stumped above.

    Would be nice to submit Eclipse GIT based patches before the commit on a branch though.
     
    Last edited:

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    S TV-Server MP1 - Automatic search doesn't work Installation, configuration support 2
    vapourEyes Automatically Re-Tune Periodically Improvement Suggestions 1
    vapourEyes Automatically Tune to Strongest Duplicate Channel Improvement Suggestions 99
    W [solved] [FIXED] Survivor season 40 not automatically matching My TVSeries 1
    G Switch to new channel at begining of program automatically Feature Requests 0
    C How do I get MediaPortal to separate recording files by channel and month? General 2
    H MP1.21F video database scan, can it be scheduled to automatically run in background General Support 5
    Steve.Rayner61 Online Videos - Automatic Updates fails 'Automatic update disabled. Check your internet connection' OnlineVideos 10
    greybox 1.20 final does not update video duration automatically 1.20 10
    greybox 1.20 final does not update video duration automatically 1.20 Pre Release 1
    Scheibes MP2 - V2.1 Meta-Data import not complete by automatic import Older releases 3
    T Client / Server slow channel-to-channel change (zapping) General Support 1
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    catavolt [WiP] When changing theme in my skins, I always get this error message in logs MediaPortal 1 9
    azzuro [WiP] MP1-4999 - Big changes with many related change at once by Sebastiii MediaPortal 1 12
    J How to change y position of subtitles General 2
    D [solved] Changed username in Win10, now TV Server config crashes on fresh install Installation, configuration support 1
    M Change size of the splash screen Skins and Plugins Installer (MPEI) 2
    S Remote button to change audio and subtitle on / off General 10
    BenGonGon chaine qui change aléatoirement Support Général 2
    R [solved] Command / Shortcut for changing subtitles or audio Archive 5
    ge2301 New forum design together with change to XF2.x Online Facilities 4
    doskabouter [Evaluate] Changing SecurityProtocol Developer Discussions 1
    O [Help Me!] How to change 'release' status in Jira? Developer Discussions 9
    cbr954rr [fixed] Movie db refresh on changes of nfo and correct spelling of words in titles 2.2 Archive 33
    Similar threads

























    Top Bottom