[TV] 4994: Automatically Change Channel on Program Reminder (1 Viewer)

vapourEyes

Portal Pro
July 31, 2013
144
43
Home Country
United Kingdom United Kingdom
Hi there, I am getting build errors on Master.

Showing this code:
using System;
using MediaPortal.GUI.Library;
using MediaPortal.Dialogs;
using TvDatabase;
using Common.GUIPlugins;
using Action = MediaPortal.GUI.Library.Action;

namespace TvPlugin
{
public abstract class RecordedBase : WindowPluginBase
{

Error 7 The type or namespace name 'GUI' does not exist in the namespace 'MediaPortal' (are you missing an assembly reference?) MediaPortal-1-master\TvEngine3\TVLibrary\TvPlugin\TvPlugin\RecordedBase.cs 2 19 TvPlugin
 

regeszter

Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Can someone apply this patch?

    git.exe am --3way --ignore-space-change --keep-cr "Z:\R\MediaPortal-1-master.patch"
    Patch format detection failed.

    Fail
     

    vapourEyes

    Portal Pro
    July 31, 2013
    144
    43
    Home Country
    United Kingdom United Kingdom
    The patch was cut at the \TvEngine3\TVLibrary\TvPlugin\TvPlugin level.
    This was to prevent artifacts at other parts of the tree from taking part in the patch.

    I hope that is ok. If not I can cut another one at the top level ?
     

    vapourEyes

    Portal Pro
    July 31, 2013
    144
    43
    Home Country
    United Kingdom United Kingdom
    Thank you... will do so shortly.
    --- Post updated ---
    Sorry about this. I have not used GIT for some time, as is becoming obvious :unsure:

    1. Pull origin/master - done.
    2. Create a new branch - done.
    3. Make your code changes - done.
    4. Commit your changes - done - but if i commit these changes, it seems I can no longer create a patch ??? ***
    5. Creating a Patch Serial
    *** - I have tried this with both Tortoise GIT and Eclipse GIT.
    It seems I have to make changes, possibly on a new branch, and then create a patch for that ?
    --- Post updated ---
    Submit patch, the sequel....
     

    Attachments

    • 0001-Automatically-change-channels-for-reminders-in-the-P.patch
      7.3 KB

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    What does it mean? ;)

    Code:
                //if (TVHome._playNotifyBeep)
                {
                  MediaPortal.Util.Utils.PlaySound("notify.wav", false, true);
     

    vapourEyes

    Portal Pro
    July 31, 2013
    144
    43
    Home Country
    United Kingdom United Kingdom
    Hi regeszter,

    I have to comment that line, to get the sound notification to work.
    I think, now, that NotifyChannelChange(), should be hosted within TvHome. If it was located within TvHome, the comment would not be needed.
    That method was based on another method, OnGlobalMessage(), within TvHome.

    Its closely based on the section of code following:
    case GUIMessage.MessageType.GUI_MSG_NOTIFY_TV_PROGRAM:

    Have you any thoughts on this ?

    *** the eclipse GIT tooling does not support Creating a Patch Serial, that I can see.
    You have to use Tortoise GIT to get the 'Create a Patch Serial' option.

    That explains why I got stumped above.

    Would be nice to submit Eclipse GIT based patches before the commit on a branch though.
     
    Last edited:

    Users who are viewing this thread

    Top Bottom