[TV] 4994: Automatically Change Channel on Program Reminder (5 Viewers)

[404]

I can confirm everything is working as expected now...Great job guys

 

[ajs]

Ok, Included in 1.25 Pre, coming soon ...

 

[vapourEyes]

Thanks @404, @ajs !

Job well done !

 

[vapourEyes]

Hello MediaPortalans...

When I first developed this I left the TV Buffer in tact, so people could go back in time to previous switched-from channels.
However, I notice the merged version resets the buffer.. boohoo.

Is it possible to effect a small change to trust the buffer and leave it in-tact between Channel changes ?

Thank you very kindly in advance if at all possible.

 

[ajs]

Is it possible to effect a small change to trust the buffer and leave it in-tact between Channel changes ?

I don't quite understand the problem, but in general you can make any changes that add functionality and don't break the Media Portal.

 

[CyberSimian]

However, I notice the merged version resets the buffer.. boohoo.
Is it possible to effect a small change to trust the buffer and leave it in-tact between Channel changes ?

I can confirm that there is a difference between manually changing the channel, and allowing the reminder to change the channel:

• If programme A is being watched, and then the channel is changed manually to programme B, it is possible to use the REWIND or JUMP_BACKWARD functions on the remote control or keyboard to return to the parts of programme A that are still in the buffer.
• If programme A is being watched, and a reminder times out and causes the channel to change to programme B, it is not possible to return to the parts of programme A that were in the buffer. Instead, the buffer limit is the point at which the switch to programme B was made.

-- from CyberSimian in the UK

 

[vapourEyes]

Hi Folks, just confirming I may dust off the old .NET IDE and submit a patch for this to leave the buffer in-tact and to also preserve 'Pause' as programs switch. It was intended to be that way in the beginning.

 

[vapourEyes]

I built the TvPlugin.dll file and will now install 1.38 and test it out.
It only needed 1 commented out line and 4 more added !

I'll keep you posted.

 

[vapourEyes]

Here is the code from TvHome.cs.
Unfortunately it neither preserves Pause(), or keeps the buffer in-tact.
Can someone please explain why at all ?

            if (tvNotifyDlg.IsConfirmed)
            {
              try
              {
                //MediaPortal.Player.g_Player.Stop();

                bool isPaused = g_Player.Paused;

                if (c.IsTv)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_TV);
                  TVHome.ViewChannelAndCheck(c);
                  if (TVHome.Card.IsTimeShifting && TVHome.Card.IdChannel == c.IdChannel)
                  {
                    g_Player.ShowFullScreenWindow();
                  }
                }
                else if (c.IsRadio)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_RADIO);
                  Radio.CurrentChannel = c;
                  Radio.Play();
                }

                if (isPaused)
                {
                  g_Player.Pause();
                }
              }
              catch (Exception e)
              {
                Log.Error("TVHome: TVNotification: Error on starting channel {0} after notification: {1} {2} {3}", notify.Channel.DisplayName, e.Message, e.Source, e.StackTrace);
              }

 

[vapourEyes]

Stop the presses !

I made a mistake. I need to rebuild the plugin at v 1.38.1 and not 1.38.3 as I have done.
I'll get to it and report back.

Thank you !!!!