[Approved] Allow plugins as Screensavers (1 Viewer)

[sccrgoalie1]

I've submitted a new pull request for allowing plugins to act as a screensaver. This involved changes to the configuration to allow you to choose a plugin as well as changes to processing Media Portal idle.

Pull Request
https://github.com/MediaPortal/MediaPortal-1/pull/32

Fork
https://github.com/sccrgoalie1/MediaPortal-3

I'll update the wiki as necessary if approved.

 

[azzuro]

hi, sccrgoalie1, thanks for your contribution. can you add more explaination how work your changes. ( i'm sorry i don't understand all )
it's related to this thread ?
https://forum.team-mediaportal.com/threads/allow-windows-screensaver-as-a-third-idle-option.112765/

 

[sccrgoalie1]

It's similar to that, but no, not the same. See the attached screenshot. I'm not sure how to describe it better, but all it does is allow you to have a plugin act as the screensaver. I created a plugin just for this purpose.

Plugin
https://www.team-mediaportal.com/extensions/pictures/mp-photo-slideshow

 

[azzuro]

i think have understand your patch change.
can be started when music is played ? ( if visualisation is not selected / or add the same support of "screensaver plugin " as visualisation support too )

 

[sccrgoalie1]

i think have understand your patch change.
can be started when music is played ? ( if visualisation is not selected / or add the same support of "screensaver plugin " as visualisation support too )

Yes, it will be started when music is playing. It will work the same as the current screensaver options.

 

[azzuro]

this is very WAF support : FINE !!!!
@megahorst is not what you want ?

 

[megahorst]

this is very WAF support : FINE !!!!
@megahorst is not what you want ?

I think this is even better ...
Now I have turned of the internal screensaver and use the windows one only. This works fine with vs. 1.4.
When this feature will be in MePo I will use the internal again ;-)

Thx

 

[Edalex]

Is it right to duplicate PluginManager plugin loading code in your patch?

 

[sccrgoalie1]

Is it right to duplicate PluginManager plugin loading code in your patch?

That's a fair point. I've just pushed a new commit that allows the two sections to share the plugin loading. There is no longer double loading or duplicated code.

 

[azzuro]

thanks, but you have update on master branch and not the good branch.
we can't import from master !
Please, only use branch dedicated for each change.
one branch = one change , more easy for Dev team to verify the code.