- Moderator
- #21
you can merge the MP branch into your own branch.
and post the patch
and post the patch
I think I did this right based on what you said. Thanks by the way! Fix pushed here.you can merge the MP branch into your own branch.
and post the patch
I thought I set visual studio correctly, I'll double check the settings. Thanks.Hi sccrgoalie1
Can you set your Visual Studio with recommended setting from wiki ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)
Your latest push in branch missing some space (you can compare the branch from MP1 repo)
Thanks
Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
Can you correct it ?
Seb.
Commit pushed to my branch that fixes this issue. I also reviewed all the coding standards and updated some spacing. If you see anything specific I'm missing please let me know and I'd be happy to fixI thought I set visual studio correctly, I'll double check the settings. Thanks.Hi sccrgoalie1
Can you set your Visual Studio with recommended setting from wiki ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)
Your latest push in branch missing some space (you can compare the branch from MP1 repo)
Thanks
Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
Can you correct it ?
Seb.
I'll check out the enable disable issue tomorrow, and fix it up.
Thanks for taking time to explain these things. I really appreciate it!Yeah thanks seems good
I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :
View attachment 137849
You see : these ...... after }, they can be removed
Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
Yours : Spacing updates
Correct one : MP1-4231 : Spacing updates
This will help to create review easily
Ps : don't get me wrong, you did a good job and with above it will like perfect
I'll update the wiki as necessary if approved