[Approved] - Allow plugins as Screensavers | Page 3

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by sccrgoalie1, October 1, 2013.

  1. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,485
    Likes Received:
    2,543
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,215 / 13
    Home Country:
    France France
    Show System Specs
    you can merge the MP branch into your own branch.
    and post the patch


     
    • Thank You! Thank You! x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
  4. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Thanks! :)
    I think @Sebastiii is the one who will push your fix into the MediaPortal branch.
     
  5. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,228 / 9
    Home Country:
    France France
    Show System Specs
  6. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    I thought I set visual studio correctly, I'll double check the settings. Thanks.

    I'll check out the enable disable issue tomorrow, and fix it up.
     
    • Thank You! Thank You! x 1
  7. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    Commit pushed to my branch that fixes this issue. I also reviewed all the coding standards and updated some spacing. If you see anything specific I'm missing please let me know and I'd be happy to fix :)
     
    • Thank You! Thank You! x 1
  8. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,228 / 9
    Home Country:
    France France
    Show System Specs
    Yeah thanks seems good :)

    I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
    Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :

    Line_end_space.JPG

    You see : these ...... after }, they can be removed :)

    Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
    Yours : Spacing updates
    Correct one : MP1-4231 : Spacing updates

    This will help to create review easily :)

    Ps : don't get me wrong, you did a good job and with above it will like perfect :)
     
    • Thank You! Thank You! x 1
  9. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    Thanks for taking time to explain these things. I really appreciate it!
     
    • Like Like x 1
  10. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    • Like Like x 1
    • Thank You! Thank You! x 1
  11. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!