[Approved] Allow plugins as Screensavers (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,448
    10,276
    France
    France France
    Country flag

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    34
    United States of America United States of America
    Hi sccrgoalie1 :)

    Can you set your Visual Studio with recommended setting from wiki :) ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

    Your latest push in branch missing some space (you can compare the branch from MP1 repo)
    Thanks :)

    Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
    Can you correct it ?

    Seb.
    I thought I set visual studio correctly, I'll double check the settings. Thanks.

    I'll check out the enable disable issue tomorrow, and fix it up.
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    34
    United States of America United States of America
    Hi sccrgoalie1 :)

    Can you set your Visual Studio with recommended setting from wiki :) ? (from here : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards)

    Your latest push in branch missing some space (you can compare the branch from MP1 repo)
    Thanks :)

    Also the latest fix is not 100% working, now we can't enable plugins disabled and can't disable plugins enabled, it's like setting is not write to xml.
    Can you correct it ?

    Seb.
    I thought I set visual studio correctly, I'll double check the settings. Thanks.

    I'll check out the enable disable issue tomorrow, and fix it up.
    Commit pushed to my branch that fixes this issue. I also reviewed all the coding standards and updated some spacing. If you see anything specific I'm missing please let me know and I'd be happy to fix :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,448
    10,276
    France
    France France
    Country flag
    Yeah thanks seems good :)

    I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
    Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :

    Line_end_space.JPG


    You see : these ...... after }, they can be removed :)

    Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
    Yours : Spacing updates
    Correct one : MP1-4231 : Spacing updates

    This will help to create review easily :)

    Ps : don't get me wrong, you did a good job and with above it will like perfect :)
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    34
    United States of America United States of America
    Yeah thanks seems good :)

    I have corrected 2005-2010 to 2005-2013 (i forgot also to change that lol)
    Remove some space at the end of line (when commit the change, you can see it and you can remove it manually) :

    View attachment 137849

    You see : these ...... after }, they can be removed :)

    Last thing i think is when we have a Jira Entry, you have to put Jira issue key in each commit message like :
    Yours : Spacing updates
    Correct one : MP1-4231 : Spacing updates

    This will help to create review easily :)

    Ps : don't get me wrong, you did a good job and with above it will like perfect :)
    Thanks for taking time to explain these things. I really appreciate it!
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    emphatic Allow remote control mapping of all plugins Improvement Suggestions 0
    N [Finished] [MP2-806] Playing a recorded radio program does not show screen to allow skipping forward, etc MediaPortal 2 141
    R MediaPortal will not allow windows shortcut keys to work OffTopic 0
    P Mediaportal does not allow my TV tuner to enter low power state General Support 1
    B [MP2-745] Allow direct navigation to specified media item/filter Archive 7
    morpheus_xx [WiP] "What's New" plugin for MP2 upgrades MediaPortal 2 20
    da3dsoul [Request] An MVP Plugin example for custom settings in MP2 Plugin Development 2
    da3dsoul MP2 Plugin - Getting Started (Directory Tree and Player) Plugin Development 27
    M Installing Plugins Newcomers Forum 2
    joecrow 1.25.0 Radio Time plugin fails after Resume from Sleep with MP 1.25 Bugreports 10
    P MP2: US user, OTA - can NOT get SchedulesDirect plugin to work on MP1 or MP2 --> how do I get OTA schedule? General 5
    E aktuelle englische Forums Webseite von - Showtime Plugin v3 Plugins & Erweiterungen 4
    mrmojo666 [Tv Server Plugin ]Direct Show Video Control Plugin 0.0.0.1 for Hauppauge PVR cards MediaPortal 1 Plugins 0
    joecrow MultiShortcut Plugin (Uavailable) in DWHD skin General Support 58
    vapourEyes Building TV Plugin General Development (no feature request here!) 49
    Golf4 Nach Windows-Updates läuft TV-Plugin nicht mehr Allgemeines Support- und Diskussionsforum 0
    joecrow How about a Launcher plugin for MP1? MediaPortal 1 6
    D [solved] TVServer Plugin must be missing something. General Development (no feature request here!) 1
    framug Nouveau plugin XmlTvFR pour récupérer le guide télé français Kazer / ZguideTv (WebEPGfr) 11
    D Where should plugins be located on hard drive? General Support 0
    D how to disengage from one version of a plugin to use another Newcomers Forum 0
    cbr954rr How to disable a pre-configured plugin? General 2
    mrmojo666 [Plugin]Marantz Control Plugin 0.0.0.2 MediaPortal 1 Plugins 2
    mrmojo666 beginner: trying to write a plugin, need help to catch event General Development (no feature request here!) 3
    framug [Rejected] Fix PowerScheduler plugin for MP2 single seat Submit: Code Patches 9
    Similar threads

























    Top Bottom