AutoCropper plugin (4 Viewers)

Seidelin

Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    652
    Kgs. Lyngby
    Home Country
    Denmark Denmark
    On my HTPC "Normal" aspect ratio results in an image not being tall enough, or in other words, I get black bars in top and bottom of the screen. With "stretch", the image is correctly displayed. As I currently do not have correct aspect ratio with "Normal", I guess I won't have it with autocropper active either.

    For me it would be ok to select whether the autocropper should preserve aspect ratio or not on the configuration page. Of course, it would be better to have the choice directly available.

    I don't know if it would be possible to make it so, but you could consider:
    Clicking autocrop once makes aspect ratio correct cropping, whereas twice stretches the image. This has the value of being intuitively simple to understand for the user. The first click removes the top and bottom black bars, and the second removes the ones on the side (if present).

    Seidelin
     

    ziphnor

    Retired Team Member
  • Premium Supporter
  • August 4, 2005
    755
    13
    Copenhagen
    Home Country
    Denmark Denmark
    Thanks for the feedback Seidelin. It is correct that *currently* the Normal zoom mode does not yield aspect correct cropping, i intend to change that.

    I have decided to do this by making the zoom modes aware of the cropping parameters. That way 'Normal' will now give an aspect correct crop (also for smaller static crops without the autocropper), stretch will only apply crop to the source rectangle, original will ignore cropping completely etc.

    Done this way, people who prefer aspect correctness at all times can stick to 'Normal' all the time, while Stretch will indeed stretch the image.

    I only just implemented this quick and dirty and wont be adding it to SVN before its tested. I hope to have time for this in the weekend.
     

    ziphnor

    Retired Team Member
  • Premium Supporter
  • August 4, 2005
    755
    13
    Copenhagen
    Home Country
    Denmark Denmark
    As of SVN rev 12585 the Normal zoom mode should remain aspect correct when cropping is applied. Feel free to report problems/issues/suggestions here.

    As a side note, the 'Original' zoom mode now completely ignores cropping as it should. If you feel this is a crime against humanity, please speak up :)
     

    Inker

    Retired Team Member
  • Premium Supporter
  • December 6, 2004
    2,055
    318
    As a side note, the 'Original' zoom mode now completely ignores cropping as it should. If you feel this is a crime against humanity, please speak up :)

    I will make srue to report you to Amnesty International! :)

    Sorry mate havent been able to test it as of yet, just too busy. But I'll be sure to give it a go this weekend.

    Keep up the great work!

    Inker
     

    maysider

    Portal Pro
    February 5, 2006
    195
    0
    super. And now comes the black work :)

    Would be really useful to have option "sesitivity" separately for my TV and my Video, maybe completely separate.

    The other function (I think it must not be missing): crop always once after launch TV, once when TV channel is changed, crop once when video is launched (maybe it is already included, so sorry :)

    And Ive noticed that in my TV when automatic autocropper changes borders always appears info about TV channel (maybe in new svn it is ok, I dont know)

    And would be nice to reserve any key to reload "manual mode"

    also would be nice to have cropper for L+R sides.

    wish a nice day

    m
     

    ziphnor

    Retired Team Member
  • Premium Supporter
  • August 4, 2005
    755
    13
    Copenhagen
    Home Country
    Denmark Denmark
    The other function (I think it must not be missing): crop always once after launch TV, once when TV channel is changed, crop once when video is launched (maybe it is already included, so sorry :)

    Thats a decent idea, but usually you get commercials before the movie in recordings, so usually the this initial crop would be wrong.

    And Ive noticed that in my TV when automatic autocropper changes borders always appears info about TV channel (maybe in new svn it is ok, I dont know)

    I will take a look, that is certainly not the intention...

    And would be nice to reserve any key to reload "manual mode"

    You can assign a key to the ACTION_AUTOCROP action (its called something like that anyway). Currently i believe F4 defaults to ACTION_AUTOCROP_TOGGLE which just switches between the enabled modes(auto/off/manual). ACTION_AUTOCROP re-computes the crop when in manual mode.

    also would be nice to have cropper for L+R sides.

    That will most likely be the next update.
     

    risu

    MP Donator
  • Premium Supporter
  • September 22, 2006
    279
    19
    Home Country
    Finland Finland
    Tried new SVN yesterday with manual cropping and normal mode. Worked like a charm, and just the way I wanted. Thanks :)
     

    maysider

    Portal Pro
    February 5, 2006
    195
    0
    The other function (I think it must not be missing): crop always once after launch TV, once when TV channel is changed, crop once when video is launched (maybe it is already included, so sorry :)

    Thats a decent idea, but usually you get commercials before the movie in recordings, so usually the this initial crop would be wrong.

    what? MP records the cropped picture? I think it is not good. Of course I would use initial crop together with automatic crop so the commercials dont obstruct. Maybe this function could be optional....especially in My video would be useful
     

    risu

    MP Donator
  • Premium Supporter
  • September 22, 2006
    279
    19
    Home Country
    Finland Finland
    No, crop is just another zoom feature. MP always records the same stream recardless the zoom mode.

    What ziphnor meant is that if you calculate crop while commercial it wouldn't be correct for the movie. So he was just giving an example why automatic manual crop while changing channel wouldn't work in general.

    Autocrop has already an option for using it with my videos. You can access it from setup plugins.
     

    Users who are viewing this thread

    Top Bottom