Broken episode thumbnail crashes MediaPortal (1 Viewer)

RoChess

Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,345
    1,824
    Country flag
    Probably some conflict with the TheTVdB data, so you will have to analyze each language, find out error, update content, and then between a few seconds and a few hours the API ZIP files will be updated for MP-TVSeries to get fixed.
     

    emphatic

    Design Group
  • Team MediaPortal
  • August 25, 2006
    3,602
    1,093
    Alingsås
    Sweden Sweden
    Country flag
    • Thread starter
    • Moderator
    • #12
    Probably some conflict with the TheTVdB data, so you will have to analyze each language, find out error, update content, and then between a few seconds and a few hours the API ZIP files will be updated for MP-TVSeries to get fixed.
    While this is true, isn't it pretty bad to have this kind of vulnerability inside a plugin?
    Emph
     

    JimCatMP

    Documentation Group
  • Team MediaPortal
  • April 1, 2010
    648
    281
    Leeds
    United Kingdom United Kingdom
    Country flag
    Solved

    The jpg downloaded is corrupt, remove it and your fine [..../thumbs/MPTVSeriesBanners/American Gods/Episodes/1x5.jpg ].

    Image appearing on TheTVDB page looks good but click on it and it's clearly broken.

    I note issue already reported and a corrected image uploaded but that is not what is being delivered from cache at the moment.

    See http://thetvdb.com/banners/episodes/253573//6082597.jpg> to get image to save it yourself, see <[Bad Thumbnail] American Gods (253573) 1x05 - TheTVDB.com> for forum reference.

    Cheers - JCMP
     

    milhouse

    Portal Pro
    November 9, 2006
    363
    54
    46
    Raleigh, NC U.S.
    United States of America United States of America
    Country flag
    In case you are curious, 12 Monkeys S03E09 seems to have the exact same issue.

    Glad to see this thread - weird issue, thought it was just me. Glad y'all have figured it out for me!

    Milhouse
     

    RoChess

    Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,345
    1,824
    Country flag
    While this is true, isn't it pretty bad to have this kind of vulnerability inside a plugin?
    Emph
    Programming = 1 line to do something
    Error-free = 1000 lines of code to do the same thing, but account for every possible condition that can go wrong and properly handle it
    Reality = 1001 lines of code next day, because you overlooked something that was never thought possible
    1002 lines of code after that
    1003 lines of code after that
    ...

    you get the point ;)
     

    emphatic

    Design Group
  • Team MediaPortal
  • August 25, 2006
    3,602
    1,093
    Alingsås
    Sweden Sweden
    Country flag
    • Thread starter
    • Moderator
    • #18
    Sure, but for a user that has no idea what's wrong will think MediaPortal sucks and uninstall it the 3rd or 4th time this happens. Some sort of safety net for when media is out of control would just be good practice IMHO.

    Emph
     

    RoChess

    Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,345
    1,824
    Country flag
    Yup, not saying you're wrong, just that it is not easy.

    Not sure if @ltfearme is still active on development, so somebody might need to look at the GitHub code and submit a patch, or assist in managing the project.
     

    JimCatMP

    Documentation Group
  • Team MediaPortal
  • April 1, 2010
    648
    281
    Leeds
    United Kingdom United Kingdom
    Country flag
    Hi all

    Assumption is this is in the plugin, but I'm not so sure - I'd assume the plugin call's standard core routines to handle image display - the DB stuff handles the path [all of which is good] and the import, but hands actual display off...... Adding image 'verification' to the plugin may be significant overhead which plugin dev may not consider appropriate - given the SRC should [will be?] correct - as RoChess says, tis far from a simple:eek:

    Idiot proof is impossible, there are just so many of them and they are beyond inventive:oops: - cretin resistant is the best you can hope for [and MPTVSeries is very resistant generally:love:

    Cheers - JCMP.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    C Grabbers broken General Support 24
    Mr6686 [solved] Titan skin broken since update to 1.23 Installation, configuration support 6
    A Help! MP2 - DVB-T Not recognised (DRIVERS?) General 12
    M [solved] IMDB script broken again General Support 67
    G Q about scheduling weekly series when epg lists duplicate back to back episodes each week General Support 2
    cladinshadows85 [solved] TV Recordings episode field blank General 20
    P TV recording not displaying episode titles or going into series General 10
    G MP 1.21 TVserver race condition when cant delete recording triggered by episode management General Support 0
    A cursor.wav or click.wav set in keyboard and keys cause recordings to be set in upcoming episodes 1.20 2
    A "upcoming episodes" arrow key set recording - Ok/rtn doesn't work General Support 9
    R TV Guide No Episode Info Displayed Electronic Program Guide 5
    Alberto83 [no Bug] Watched status not retained when rewatching an episode and stopping. Archive 49
    A Filenaming Season and Episode Numbers not working General Support 1
    B Episodes to Keep and Priority for Schedules in MP2 General 0
    U Parsing invalid episode names My TVSeries 10
    CyberSimian [Bug] 5035: ZoomPixels in a thumbnail list MediaPortal 1 13
    H [solved] Video database genres, sort titles and collection thumbnails Newcomers Forum 12
    G [fixed] No recorded video thumbnails created while recording. 2.2 Archive 2
    F [Solved] Movies View with Thumbnail Layou General Support 4
    J Question about thumbnail decorations MediaPortal 1 Talk 0
    volumia Q: thumbnail creation for Pictures plugin MediaPortal 1 Plugins 3
    A Thumbnails - where are they stored Installation, configuration support 20
    H MP 2.2 - Rework thumbnail handling Archive 43
    Similar threads























    Top Bottom