Broken episode thumbnail crashes MediaPortal | Page 2

Discussion in 'My TVSeries' started by emphatic, June 3, 2017.

  1. RoChess
    • Premium Supporter

    RoChess Extension Developer

    Joined:
    March 10, 2006
    Messages:
    4,153
    Likes Received:
    1,294
    Ratings:
    +1,659 / 2
    Probably some conflict with the TheTVdB data, so you will have to analyze each language, find out error, update content, and then between a few seconds and a few hours the API ZIP files will be updated for MP-TVSeries to get fixed.


     
    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. emphatic
    • Team MediaPortal

    emphatic Design Group

    Joined:
    August 25, 2006
    Messages:
    3,581
    Likes Received:
    828
    Gender:
    Male
    Occupation:
    Surface treatment
    Location:
    Alingsås
    Ratings:
    +1,082 / 2
    Home Country:
    Sweden Sweden
    Show System Specs
    While this is true, isn't it pretty bad to have this kind of vulnerability inside a plugin?
    Emph
     
  4. JimCatMP
    • Team MediaPortal

    JimCatMP Documentation Group

    Joined:
    April 1, 2010
    Messages:
    646
    Likes Received:
    152
    Gender:
    Male
    Location:
    Leeds
    Ratings:
    +281 / 1
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Solved

    The jpg downloaded is corrupt, remove it and your fine [..../thumbs/MPTVSeriesBanners/American Gods/Episodes/1x5.jpg ].

    Image appearing on TheTVDB page looks good but click on it and it's clearly broken.

    I note issue already reported and a corrected image uploaded but that is not what is being delivered from cache at the moment.

    See http://thetvdb.com/banners/episodes/253573//6082597.jpg> to get image to save it yourself, see <[Bad Thumbnail] American Gods (253573) 1x05 - TheTVDB.com> for forum reference.

    Cheers - JCMP
     
    • Like Like x 1
    • Thank You! Thank You! x 1
    • Great Idea! Great Idea! x 1
    • Informative Informative x 1
  5. emphatic
    • Team MediaPortal

    emphatic Design Group

    Joined:
    August 25, 2006
    Messages:
    3,581
    Likes Received:
    828
    Gender:
    Male
    Occupation:
    Surface treatment
    Location:
    Alingsås
    Ratings:
    +1,082 / 2
    Home Country:
    Sweden Sweden
    Show System Specs
    Just confirming that removing the broken image worked for me. Thanks!

    Emph
     
    • Like Like x 2
  6. milhouse

    milhouse Portal Pro

    Joined:
    November 9, 2006
    Messages:
    363
    Likes Received:
    27
    Occupation:
    R&amp;D IS for a seed company
    Location:
    Raleigh, NC U.S.
    Ratings:
    +31 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    In case you are curious, 12 Monkeys S03E09 seems to have the exact same issue.

    Glad to see this thread - weird issue, thought it was just me. Glad y'all have figured it out for me!

    Milhouse
     
    • Like Like x 1
  7. emphatic
    • Team MediaPortal

    emphatic Design Group

    Joined:
    August 25, 2006
    Messages:
    3,581
    Likes Received:
    828
    Gender:
    Male
    Occupation:
    Surface treatment
    Location:
    Alingsås
    Ratings:
    +1,082 / 2
    Home Country:
    Sweden Sweden
    Show System Specs
    Changed the thread title as it's more helpful, I think.

    Emph
     
    • Great Idea! Great Idea! x 1
  8. RoChess
    • Premium Supporter

    RoChess Extension Developer

    Joined:
    March 10, 2006
    Messages:
    4,153
    Likes Received:
    1,294
    Ratings:
    +1,659 / 2
    Programming = 1 line to do something
    Error-free = 1000 lines of code to do the same thing, but account for every possible condition that can go wrong and properly handle it
    Reality = 1001 lines of code next day, because you overlooked something that was never thought possible
    1002 lines of code after that
    1003 lines of code after that
    ...

    you get the point ;)
     
  9. emphatic
    • Team MediaPortal

    emphatic Design Group

    Joined:
    August 25, 2006
    Messages:
    3,581
    Likes Received:
    828
    Gender:
    Male
    Occupation:
    Surface treatment
    Location:
    Alingsås
    Ratings:
    +1,082 / 2
    Home Country:
    Sweden Sweden
    Show System Specs
    Sure, but for a user that has no idea what's wrong will think MediaPortal sucks and uninstall it the 3rd or 4th time this happens. Some sort of safety net for when media is out of control would just be good practice IMHO.

    Emph
     
  10. RoChess
    • Premium Supporter

    RoChess Extension Developer

    Joined:
    March 10, 2006
    Messages:
    4,153
    Likes Received:
    1,294
    Ratings:
    +1,659 / 2
    Yup, not saying you're wrong, just that it is not easy.

    Not sure if @ltfearme is still active on development, so somebody might need to look at the GitHub code and submit a patch, or assist in managing the project.
     
    • Agree Agree x 1
  11. JimCatMP
    • Team MediaPortal

    JimCatMP Documentation Group

    Joined:
    April 1, 2010
    Messages:
    646
    Likes Received:
    152
    Gender:
    Male
    Location:
    Leeds
    Ratings:
    +281 / 1
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Hi all

    Assumption is this is in the plugin, but I'm not so sure - I'd assume the plugin call's standard core routines to handle image display - the DB stuff handles the path [all of which is good] and the import, but hands actual display off...... Adding image 'verification' to the plugin may be significant overhead which plugin dev may not consider appropriate - given the SRC should [will be?] correct - as RoChess says, tis far from a simple:eek:

    Idiot proof is impossible, there are just so many of them and they are beyond inventive:oops: - cretin resistant is the best you can hope for [and MPTVSeries is very resistant generally:love:

    Cheers - JCMP.
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!