BUG: cannot match shows with ' in name (1 Viewer)

[gamejester]

Not a major one, and via the config setup app you can type in the ' when it is not found, but might be an easy one to fix.

Local shows cannot contain ' as it is an invalid char.

When searching for any show where an s is seen with spaces on either side at the end of a word why not auto incert the '

Again, sorry not looked at the code, but I image if the series looks like

It s Always Sunny in Philadelphia

you could do something like

strShow = strShow.Replace(" s ", "'s ");

before you try to match it to an online show.

 

[fforde]

I tested this yesterday with the latest source code and it worked fine. I can confirm that "it s always sunny in philadelphia" doesn't work, but with the apostrophe in there or with no apostrophe and no space it works fine. Do you have a string replace rule that pulls out apostrophes and replaces them with a space? Maybe try removing the rule or changing it to replace the apostrophe with nothing.

 

[gamejester]

I am using the SVN from today, so I do not think you understand the issue (or maybe I m not understanding you).

You say

"it s always sunny in philadelphia"

does not work, OK, this is correct and this is the iissue.

I use the standard downlaod, rename, move utils that are out there with the standard string replacement.
Whilst I could do what you say I am trying to make MP and especially the myTVseries plugin as easy to use as possible for the average user, and thus a lot of users will have shows and folders named like this.

It would be simple to add this logic, as I have described, to the code, rather than expecting users to have to rename all their shows.

I am sure there is already some sort of logic going on in myTVseries plugin as matched like

CSI Miami match to CSI: Miami
and
its always sunny in philadelphia matched to "it's always sunny in philadelphia"

Not a big deal and thanks for your suggestion.

 

[fforde]

I see, I misunderstood your thread title. I thought you meant you actually had problems with titles with an apostrophe. You are right though with the space there it still should match, that's only a single character difference.

 

[ltfearme]

What about adding a new default string replacement for this?

<space>s<space> -> 's<space>

Damien

 

[Inker]

What about adding a new default string replacement for this?

<space>s<space> -> 's<space>

Damien

Yes, that's way better than custom coding something. Just make sure this one doesn't run before matching or else stuff like "Series S 1 E 01 - Title.avi" will fail (I think the default regex don't match this anyways, but you can easily imagin a slight modification).

Ideally the onlineDB would allow for such inaccuracies in the search term, but for the time being this is the best solution, even if it doesn't solve the problem when there is no space (as in "Its always sunny...")

 

[gamejester]

OK, fair enough, just thought the code was already handling some string replacements already as I had seen things like

CSI miami match with CSI: miami

Good suggestion with the string replacement in the plugin, did not think of that, I had already sorted my case by altering my own download, rename, move scripts; but your way would have been quicker.

Like I said, not a big deal for me personally, only really got a bit teadiousous when i was reloading my DB 30 times a day to do testing!

thanks guys.

 

[ltfearme]

OK, fair enough, just thought the code was already handling some string replacements already as I had seen things like

CSI miami match with CSI: miami

Nothing special, it does a replace on ' ' with '+' and then a query like this:

http://thetvdb.com/api/GetSeries.php?seriesname=csi+miami&language=en

Damien