[WiP] Changing channel using numbers does not work across group (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,434
    10,256
    France
    France France
    Country flag
    In fact less we touch TVE3 and more speedy TVE3.5 will comes.
    If it's minor change then we need a branch for TVE3 and also TVE3.5.

    TVE3.5 doesn't work anymore with gentle etc. so touching the SQL is tricky.
    Better to do profile for TVE3.5.

    But yes i'm using the lock groups on my side and this one can be ported to TVE3.5 if it didn't enter in conflict on TVE3.5 feature :p
     

    daWooky

    MP Donator
  • Premium Supporter
  • April 3, 2012
    779
    868
    Germany Germany
    Country flag
    edit the group channels so what?

    edit: sorry guys but imho its only reasonable if scanned channels not get listed on 10000:rolleyes:
     
    Last edited:

    Stéphane Lenclud

    Development Group
  • Team MediaPortal
  • April 29, 2013
    2,563
    1,288
    Germany Germany
    Country flag
    can you please explain, the goal of this one ?
    Did you read the title of that thread? I can hardly make it any clearer I'm afraid.
    The first post goes into some details too.

    The goal is that, when you do channel selection using numbers on your remote, it will jump to the channel matching the given number, even if that channel is not in the current group.
    Hope that helps.
     

    Stéphane Lenclud

    Development Group
  • Team MediaPortal
  • April 29, 2013
    2,563
    1,288
    Germany Germany
    Country flag
    I'm quite excited about that change as it would allow users to make the most of applications such as Peel Smart Remote for smartphone and Harmony channel shortcuts while still using channel groups.
     

    Stéphane Lenclud

    Development Group
  • Team MediaPortal
  • April 29, 2013
    2,563
    1,288
    Germany Germany
    Country flag
    edit the group channels so what?

    edit: sorry guys but imho its only reasonable if scanned channels not get listed on 10000:rolleyes:
    I don't quite follow what you're saying. Could you explain further?
    Feel free to post in German if that's quicker for you.
     

    mm1352000

    Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    Just reviewing the current change...

    Scan current group first thus enabling consistent duplicate channel numbers behavior.
    I agree, this is very important. In my opinion people will expect to stay within the current group unless they explicitly select a channel that is not in the current group.

    Having looked at the code more thoroughly now...
    What you've got generally looks good. (y)
    Only two additional comments (opinions! :) ):
    1. I think it would be more consistent not to try to avoid going to the all channels group. If people want to avoid the all channels group, they can use the "hide all channels group" setting... or simply configure it to be the last group. (As you know, groups have a defined sort order. m_groups is already sorted according to that ordering and excludes the all channels group according to the setting value. After checking the current group, you could simply iterate over m_groups until you find the channel.)
    2. If possible, I would only set the current group after trying to select the target channel, and only if zapping is successful.
    I was also going to add that the all channels group could be completely skipped if the user has ticked the "hide all channels group" option, but the current code already does that (m_groups is filtered on initial load). (y)

    Thanks! :)
     
    Last edited:

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    A UK Freeview channel changes Installation, configuration support 14
    T Client / Server slow channel-to-channel change (zapping) General Support 1
    Ralph Holmes Missing TV channels after transmitter change (Tacolneston) General 6
    ToothFaerie MP1 (1.19.0_Final) 2 minutes wait between channel changes. General Support 8
    A Channel changes in UK General Support 14
    Charlie TV [solved] Channels disappeared after transmitter changes (Midhurst) General Support 4
    toricred Recordings Change : to _ in Series Name General 0
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    catavolt [WiP] When changing theme in my skins, I always get this error message in logs MediaPortal 1 9
    azzuro [WiP] MP1-4999 - Big changes with many related change at once by Sebastiii MediaPortal 1 12
    J How to change y position of subtitles General 3
    D [solved] Changed username in Win10, now TV Server config crashes on fresh install Installation, configuration support 1
    M Change size of the splash screen Skins and Plugins Installer (MPEI) 2
    S Remote button to change audio and subtitle on / off General 10
    BenGonGon chaine qui change aléatoirement Support Général 2
    R [solved] Command / Shortcut for changing subtitles or audio Archive 5
    ge2301 New forum design together with change to XF2.x Online Facilities 4
    doskabouter [Evaluate] Changing SecurityProtocol Developer Discussions 1
    O [Help Me!] How to change 'release' status in Jira? Developer Discussions 9
    cbr954rr [fixed] Movie db refresh on changes of nfo and correct spelling of words in titles 2.2 Archive 33
    KlausWirn Music crash Bass crash no change to play music Installation, configuration support 2
    F Somethings changed - mce remote General Support 9
    N [will not fix] Changed settings do not take effect until MP2-Client is stopped and restarted. Submit: Bug Reports 4
    M reimport of movies with changed nfo files General 14
    R [solved] Change Server name General 1
    Similar threads

























    Top Bottom