[WiP] - Changing channel using numbers does not work across group | Page 2

Discussion in 'Area 51 - Testing Area' started by Stéphane Lenclud, October 2, 2016.

  1. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,264
    Likes Received:
    6,218
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,224 / 9
    Home Country:
    France France
    Show System Specs
    In fact less we touch TVE3 and more speedy TVE3.5 will comes.
    If it's minor change then we need a branch for TVE3 and also TVE3.5.

    TVE3.5 doesn't work anymore with gentle etc. so touching the SQL is tricky.
    Better to do profile for TVE3.5.



    But yes i'm using the lock groups on my side and this one can be ported to TVE3.5 if it didn't enter in conflict on TVE3.5 feature :p
     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. daWooky
    • Premium Supporter

    daWooky MP Donator

    Joined:
    April 3, 2012
    Messages:
    774
    Likes Received:
    396
    Gender:
    Male
    Ratings:
    +924 / 0
    Home Country:
    Germany Germany
    whats the piont of using it?
     
  4. regeszter
    • Premium Supporter

    regeszter Retired Team Member

    Joined:
    October 29, 2005
    Messages:
    5,335
    Likes Received:
    2,863
    Ratings:
    +5,152 / 18
    Home Country:
    Hungary Hungary
    What?
     
  5. daWooky
    • Premium Supporter

    daWooky MP Donator

    Joined:
    April 3, 2012
    Messages:
    774
    Likes Received:
    396
    Gender:
    Male
    Ratings:
    +924 / 0
    Home Country:
    Germany Germany
    edit the group channels so what?

    edit: sorry guys but imho its only reasonable if scanned channels not get listed on 10000:rolleyes:
     
    Last edited: October 11, 2016
  6. Stéphane Lenclud
    • Team MediaPortal

    Stéphane Lenclud Development Group

    Joined:
    April 29, 2013
    Messages:
    2,562
    Likes Received:
    657
    Gender:
    Male
    Ratings:
    +1,270 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Did you read the title of that thread? I can hardly make it any clearer I'm afraid.
    The first post goes into some details too.

    The goal is that, when you do channel selection using numbers on your remote, it will jump to the channel matching the given number, even if that channel is not in the current group.
    Hope that helps.
     
  7. Stéphane Lenclud
    • Team MediaPortal

    Stéphane Lenclud Development Group

    Joined:
    April 29, 2013
    Messages:
    2,562
    Likes Received:
    657
    Gender:
    Male
    Ratings:
    +1,270 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Last edited: October 12, 2016
  8. Stéphane Lenclud
    • Team MediaPortal

    Stéphane Lenclud Development Group

    Joined:
    April 29, 2013
    Messages:
    2,562
    Likes Received:
    657
    Gender:
    Male
    Ratings:
    +1,270 / 8
    Home Country:
    Germany Germany
    Show System Specs
    I'm quite excited about that change as it would allow users to make the most of applications such as Peel Smart Remote for smartphone and Harmony channel shortcuts while still using channel groups.
     
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,264
    Likes Received:
    6,218
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,224 / 9
    Home Country:
    France France
    Show System Specs
    For sure, if we want it in master, we need a TVE3.5 branch for it :)
     
  10. Stéphane Lenclud
    • Team MediaPortal

    Stéphane Lenclud Development Group

    Joined:
    April 29, 2013
    Messages:
    2,562
    Likes Received:
    657
    Gender:
    Male
    Ratings:
    +1,270 / 8
    Home Country:
    Germany Germany
    Show System Specs
    I don't quite follow what you're saying. Could you explain further?
    Feel free to post in German if that's quicker for you.
     
  11. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    Just reviewing the current change...

    I agree, this is very important. In my opinion people will expect to stay within the current group unless they explicitly select a channel that is not in the current group.

    Having looked at the code more thoroughly now...
    What you've got generally looks good. (y)
    Only two additional comments (opinions! :) ):
    1. I think it would be more consistent not to try to avoid going to the all channels group. If people want to avoid the all channels group, they can use the "hide all channels group" setting... or simply configure it to be the last group. (As you know, groups have a defined sort order. m_groups is already sorted according to that ordering and excludes the all channels group according to the setting value. After checking the current group, you could simply iterate over m_groups until you find the channel.)
    2. If possible, I would only set the current group after trying to select the target channel, and only if zapping is successful.
    I was also going to add that the all channels group could be completely skipped if the user has ticked the "hide all channels group" option, but the current code already does that (m_groups is filtered on initial load). (y)

    Thanks! :)
     
    Last edited: October 13, 2016
    • Thank You! Thank You! x 3
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!