MP2 - Spring'16 [MP-638] Cropped images by SkinEngine (1 Viewer)

[ge2301]

There is a huge bug in skin engine, that makes skinning very hard and partly prevents a professional visual appearance.
When adding images, the skin engine always crops 1-2 pixel from the bottom and right side. Especially for round images it looks terrible. Just look at below screenshot and it's clearly visible.

Moreover this makes masks on images also not work correctly.
Would be great, if this problem can be solved. Currently I have to add larger images, knowing that the skin engine crops something away.

 

[morpheus_xx]

Can you please create a single test screen inside the GuiTest plugin that can reproduce this issue? I need a simple screen with only one cropped image for debugging.

My guess is that this only happens in combination with alpha mask.

 

[ge2301]

Can you please create a single test screen inside the GuiTest plugin that can reproduce this issue? I need a simple screen with only one cropped image for debugging.

My guess is that this only happens in combination with alpha mask.

Ok, I'll do so. How can I test the result? I found the plugin, but never saw an plugin or menu entry in MP2?

 

[morpheus_xx]

It's available when compiled in Debug mode, you'll find it under "others"

 

[ge2301]

compiled in Debug mode

I have honestly no idea how to do that Before asking more questions, I better attach the default skin of the TestGui with the added screen

 

[ge2301]

@morpheus_xx , was my attachment enough to find the problem? Otherwise you need to explain how to compile in debug mode, I have no clue about it

 

[ge2301]

I think that the same bug is also causing the graphic errors in shadows and focus frames, that are build from several image tiles.

There is always something cropped from the side and the gap remains.

 

[morpheus_xx]

Yes, agree. I just stumbled upon the same effect. I made some adjustments to size calculation and was able to eliminate the gaps.

But at the same time the cut-off increased (this time in top/left). So it's very difficult to really fix this.

 

[morpheus_xx]

Can you check out this new branch? "EXP_FixCroppedImage". I've added a new test-screen for GUITestPlugin and an example image (only 1-pixel borders).

With my change on ImageContext class the rendered result now looks good (see test screen). But I'm not sure if this fixes the "gaps" from your screenshot above, so maybe there are more problems....

The GUITest plugin is compiled in DEBUG builds, you have to select it:

 

[ge2301]

I guess your change should be also visible for other images than in the test screen, right? Or is it only valid for the test screen currently?
I couldn't see any improvement unfortunately.
It looks still like this:

But the other problem seems even worse or at least equal. If you ask me, it seems the gap is 0.5 to 1 pixel larger now.