MP2 - Spring'16 [MP-638] Cropped images by SkinEngine (1 Viewer)

[ge2301]

@Brownard
You have already added a lot of great features to image controls, so you could perhaps also take a look on this bug by time.
It's not a critical bug, but takes a lot of visual quality unfortunately Morpheus_xx has already tried to fix it, but so far there is no solution.
As this bug exists already since years and we survived, there is no time pressure

 

[morpheus_xx]

When I saw the place for the texture alignment extensions, I had the same idea. My change is in the same part, but the result is not yet right. I'm currently out of ideas what the original cause for this problem is.

IIRC the issue is no longer present in the DX11/D2D branch, but currently I doubt that this one will ever get finished

 

[ge2301]

IIRC the issue is no longer present in the DX11/D2D branch, but currently I doubt that this one will ever get finished

If this is the case we could perhaps also reconsider to add a few basic effects (dropshadow and glow). So far we were mainly waiting for DX11 to avoid double efforts I think.
With those effects availabe, also my "selfmade" shadows and glows could be replaced as I don't like those too much anyway

 

[ge2301]

I rechecked the branch with the first trial to fix it. There is at least partly an improvement. It seems that the code does not work correctly because dependent on the image size yet.
You can see in the screenshot, that for the smaller tile the left side looks correct, but for the large tile only the upper right corner looks fine.



@Brownard
Can you try to take a look as "image expert"?

 

[HTPCSourcer]

@morpheus_xx , where do we stand on this?

The issue appears to still be there. Did your (partial) fix go into the Summer 16?

 

[morpheus_xx]

Unfortunately there is no fix for this issue yet. The former test where not successful and I also have no further idea

 

[HTPCSourcer]

I see.

Yet ge2301 wrote that he observed improvements with your changes from this thread. Were these changes pushed into the Summer 16 branch?

 

[morpheus_xx]

The change is only inside an experimental branch:

Can you check out this new branch? "EXP_FixCroppedImage".

It's not part of releases or weekly builds because it didn't really fix the issue, only shifted it a bit

 

[HTPCSourcer]

Yeah, but a bit is still better than nothing.

I propose to leave the decision to @ge2301 who can better judge from a skinning perspective if this should be made part of the next weekly.

 

[ge2301]

Perhaps it's good, that also other Dev's take a look before @Developers
It seems to me a dirty tricky, but perhaps small issue. More than 2 eyes may find something.
I checked the fix only on some screens, not sure, if there are side effects possible. As it's only about a few pixel, it's not directly visible.