Enabling DVB-subtitles on bad reception causes MP to crash (1 Viewer)

[risu]

This issue is old and has been around for months even before RC-stage, and also could have been around always. When DVB-signal has errors, sometimes watching clip with DVB subtitles enabled causes MP to crash. If subtitles are turned off from configuration, clips play just fine.

I've seen this happen with following tuners: Technotrend C-1500, FireDTV DVB-C (both DVB-C tuners) and with Pinnacle PCTV 2000e (DVB-t) and on two different apartments. Happens with XP SP2 and Vista 32-bit. Even motherboard + display adapter has changed so there's no common things with HW or SW (I've frequently updated MP to newer SVN) which causes this. This makes me believe there's some part on subtitle decoding/error handling which doesn't do it's job well with bad input data.

I'm uploading two sample clips that can be used to reproduce the crash. They can be found at MP dump/dvb subtitles as yle2_subtitle_crash.ts + yle2_bad_reception_subs_crash.ts

 

[risu]

Debug-build gives following after crash:

Additional Information: DLL 'C:\Windows\assembly\GAC\Microsoft.DirectX.DirectInput\1.0.2902.0__31bf3856ad364e35\Microsoft.DirectX.DirectInput.dll' is attempting managed execution inside OS Loader lock. Do not attempt to run managed code inside a DllMain or image initialization function since doing so can cause the application to hang.

 

[tourettes]

yle2_bad_reception_subs_crash.ts <-- Fixed - Mantis 0001347: Bad reception can crash DVB subtitle filter - MediaPortal Bugtracker

yle2_subtitle_crash.ts <-- wasnt able to reproduce the crash. Dunno why its not crashing here.

 

[risu]

yle2_bad_reception_subs_crash.ts <-- Fixed - Mantis 0001347: Bad reception can crash DVB subtitle filter - MediaPortal Bugtracker

yle2_subtitle_crash.ts <-- wasnt able to reproduce the crash. Dunno why its not crashing here.

Confirm that the first clip issue is now fixed. Latter is still crashing @ 7:16.

I get this when MediaPortal crashes:

Description:
Stopped working

Problem signature:
Problem Event Name: APPCRASH
Application Name: MediaPortal.exe
Application Version: 0.9.2.19186
Application Timestamp: 483cf6f2
Fault Module Name: MSVCR80.dll
Fault Module Version: 8.0.50727.1434
Fault Module Timestamp: 4757746d
Exception Code: c0000005
Exception Offset: 000172ea
OS Version: 6.0.6001.2.1.0.256.1
Locale ID: 1035

 

[risu]

Here are the logs from HTPC after the crash.

 

[tourettes]

Fixed the 2nd issue.