[fixed] EPG - Inconsistent behaviour when scrolling with page up/down (1 Viewer)

glenn 1990

Portal Pro
July 1, 2010
247
36
Belgium Belgium
Small adjustment, delete the + 1 (marked red).

Code:
        private void OnPageUp()
        {
            int Steps;
            if (_singleChannelView)
                Steps = _channelCount; // all available rows
            else
            {
                if (_guideContinuousScroll)
                {
                    Steps = _channelCount; // all available rows
                }
                else
                {
                    // If we're on the first channel in the guide then allow one step to get back to the end of the guide.
                    if (_channelOffset == 0 && _cursorX == 0)
                    {
                        Steps = 1;
                    }
                    else
                    {
                        // only number of additional avail channels
                        Steps = Math.Min(_channelOffset + _cursorX [COLOR="Red"][B]+ 1[/B][/COLOR], _channelCount);
                    }
                }
            }

            UnFocus();
            for (int i = 0; i < Steps; ++i)
            {
                OnUp(true, true);
            }
            Correct();
            Update(false);
            SetFocus();
        }
 

Wbunaarf

Test Group
  • Team MediaPortal
  • December 9, 2005
    534
    103
    Sweden
    Sweden Sweden
    Country flag
    • Thread starter
    • Moderator
    • #22
    Hi,

    I don't think this is in mantis yet, and I don't want it forgotten. Looking at the code provided, I suspect it will be straightforward, to fix, but needs to be done in TV and radio EPG.
    Should I try the different cases more (channel or program highlighted, channel 1-5 or >6) any further, or do you have enough information for now? Without having tested it more thoroughly, I have the feeling that for me it doesn't matter what's highlighted and only 6 and 7 stops on 1.
     
    Last edited:

    glenn 1990

    Portal Pro
    July 1, 2010
    247
    36
    Belgium Belgium
    I'm running the 4TR tuner, not mp tv server. So it's difficult to create a patch for it.
    Just replace OnPageUp() with this and it should work.

    Code:
            private void OnPageUp()
            {
                int Steps;
                if (_singleChannelView)
                    Steps = _channelCount; // all available rows
                else
                {
                    if (_guideContinuousScroll)
                    {
                        Steps = _channelCount; // all available rows
                    }
                    else
                    {
                        // If we're on the first channel in the guide then allow one step to get back to the end of the guide.
                        if (_channelOffset == 0 && _cursorX == 0)
                        {
                            Steps = 1;
                        }
                        else
                        {
                            // only number of additional avail channels
                            Steps = Math.Min(_channelOffset + _cursorX /*+ 1*/, _channelCount);
                        }
                    }
                }
    
                UnFocus();
                for (int i = 0; i < Steps; ++i)
                {
                    OnUp(true, true);
                }
                Correct();
                Update(false);
                SetFocus();
            }
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    Hi,

    Thanks. I made this change in TVGuideBase.cs and RadioGuideBase.cs, and can no-longer reproduce the problem. I guess it needs someone else to check.

    I am reluctant to post a binary here for testing, as it is based on latest SVN with other fixes, and has the wrong version number.

    Mark
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    652
    Kgs. Lyngby
    Denmark Denmark
    Country flag
    It would be nice if someone could confirm this different issue, now we are discussing EPG issues:

    0. Configuration. TVClient -> Make sure loop guide seamlessly is not ticked.
    1. Go to TV guide.
    2. Scroll to one of the last channels in EPG (one of the last 8 channels if using default skins).
    3. Click the channel to start watching.
    4. Click Esc (back).
    5. Observe that the guide is looped. The first few channels are shown in bottom of guide (bug). This should not happen as seamless is OFF. When scrolling down it stops at the lowest channel (which is channel no. 2 in my testing) and waits for wrap around timeout to expire.
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    It would be nice if someone could confirm this different issue, now we are discussing EPG issues:

    0. Configuration. TVClient -> Make sure loop guide seamlessly is not ticked.
    1. Go to TV guide.
    2. Scroll to one of the last channels in EPG (one of the last 8 channels if using default skins).
    3. Click the channel to start watching.
    4. Click Esc (back).
    5. Observe that the guide is looped. The first few channels are shown in bottom of guide (bug). This should not happen as seamless is OFF. When scrolling down it stops at the lowest channel (which is channel no. 2 in my testing) and waits for wrap around timeout to expire.
    Yes, confirmed as reported in the internal team forum.

    Mark
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    I tested the modified code, and it works for me as well.
    Patch attached if anyone else wants to test.
    Since I have already tested this modification here, and you have now tested it, I guess we can consider it tested.

    :)

    Mark
     

    glenn 1990

    Portal Pro
    July 1, 2010
    247
    36
    Belgium Belgium
    There are even more bugs (in the 4TR guide anyway).
    1) Try navigating with (page) up/down in a channelgroup with less channels than the rows in the guide (10 for default wide If I'm right).
    2) Index can be out of range when switching from a larger to a smaller channel group.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    M Add Radio channels and EPG to Mediaportal xmlTV 2
    M EPG color by length of TV-show MediaPortal 1 Talk 1
    D Downloading EPG XML file: Installation, configuration support 0
    D EPG No Data General Support 2
    D [solved] EPG Data off by -20 hours? General 10
    G Q about scheduling weekly series when epg lists duplicate back to back episodes each week General Support 2
    F Mini EPG more information? WMC Skin 4
    N No TV or EPG on fresh install General 0
    framug No color in TVGuide when XMLTV without DVB EPG MediaPortal 1 Talk 59
    T Freesat EPG in UK anyone? Electronic Program Guide 78
    Dark Eyes TVService locks up or fails to restart on resuming from sleep, and crashes when grabbing EPG Installation, configuration support 7
    G Movie release date in guide Electronic Program Guide 2
    Rob Hexenmeister Navigation problems adding menu buttons to EPG General Support 1
    404 [solved] EPG problem after Win10 'upgrade' General Support 1
    CyberSimian [fixed] MP1-4990 : Improve horizontal scrolling in the EPG MediaPortal 1 10
    framug [EPG] Some problems with DVB EPG Improvement Suggestions 49
    D [solved] EPG Buddy for MP2 - Does it work? General 5
    J Understanding what EPG shows about schedules General 8
    geotwticher TV Guide EPG Grabber for Australia 2020 RIP freepg.tv General 4
    B [solved] MP2.2.3 TV Guide not scrolling with mouse wheel General 2
    HTPCSourcer Special (foreign) characters don't display correctly in EPG MediaPortal 2 4
    B How to Search MP2 for Movies only in 7 day EPG that comes from the Antenna General 3
    F EPG Buddy download Plugins & Erweiterungen 1
    P Timeshifting in XMLTV General 2
    J Odd issues with Freesat EPG - MP2 General 18
    Similar threads

























    Top Bottom