EventGhostPlus (1 Viewer)

[michael_t]

Hmmm that maybe @michael_t :

Removed code :

      // TODO: should not call return here, no process plugins should be allowed to abort windows message processing
      // forward message to process plugins
      if (PluginManager.WndProc(ref msg))
      {
        // msg.Result = new IntPtr(0); <-- do plugins really set it on their own?
        return;
      }

What do you think ?

Oops, the PluginManager.WndProc(ref msg) is not called on every message type, so obviously the message the event ghost plugin is waiting for is omitted. There must be a "default:" clause added to the switch statement...

Michael

 

[OleDK]

I can confirm that it fixes the problem with MP 1.6 and Eventghost. Thanks.

 

[Sebastiii]

Hmmm that maybe @michael_t :

Removed code :

      // TODO: should not call return here, no process plugins should be allowed to abort windows message processing
      // forward message to process plugins
      if (PluginManager.WndProc(ref msg))
      {
        // msg.Result = new IntPtr(0); <-- do plugins really set it on their own?
        return;
      }

What do you think ?

Oops, the PluginManager.WndProc(ref msg) is not called on every message type, so obviously the message the event ghost plugin is waiting for is omitted. There must be a "default:" clause added to the switch statement...

Michael

I can share the code but i will push it in a branch with code review, like this you can confirm if it's ok or needed change

 

[michael_t]

I can share the code but i will push it in a branch with code review, like this you can confirm if it's ok or needed change

This is ok. I just opened a new JIRA issue MP1-4333 for the bug.

Michael

 

[Sebastiii]

Thanks branch / review created

 

[Sebastiii]

New bin based on Michael code review
Please test
Thanks

 

[davizator]

Yes, it works....thank you

 

[applebee1]

Also working here...

Thanks ;-)

 

[ikklepaul]

All sorted thanks

 

[nzdreamer55]

Great. I felt like I was taking crazy pills for a little while. Glad that I'm not the only one with the problem but not glad that there is a problem :-(