Fanart Handler Plugin v4.0.X.000 (4 Viewers)

[yoavain]

I've updated LMH installer
Check thread https://forum.team-mediaportal.com/threads/latestmediahandler-v2-0-0-18.129072/

 

[ajs]

I've updated LMH installer

Need to see the place in which it interacts with FH, maybe it's worth it to change that

 

[jameson_uk]

I have uploaded a version of MusicInfoHandler that allows you to whatever folders you want now.

If you are looking at this can I suggest you take a look at the matching / naming criteria as I remember this being an issue. IIRC FH would not match bands like "+44" and would display would do a like rather than = so on the A-Z page it would match the U2 image for the letter U and the M83 image for M. Also IIRC it would do something like match the image for Gun for Guns 'N' Roses. I made the naming artist_{x} which for some reason I thought worked better.

 

[ajs]

IIRC FH would not match bands like "+44" and would display would do a like rather than = so on the A-Z page it would match the U2 image for the letter U and the M83 image for M. Also IIRC it would do something like match the image for Gun for Guns 'N' Roses.

Is it true? Or am I already corrected?

 

[HomeY]

@ajs seems resume from standby is creating multiple instances of FH to run again?

03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting. 
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting. 
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting. 
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151 
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151 
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151 
03-Jan-2015 11:31:20  Info [               Utils]: Fanart Handler folder initialize starting. 
03-Jan-2015 11:31:20  Info [               Utils]: Fanart Handler folder initialize starting.

Wasn't this fixed in a previous version?

 

[ajs]

seems resume from standby is creating multiple instances of FH to run again?

Yes

Wasn't this fixed in a previous version?

I do not know how to fix it.

 

[HomeY]

I do not know how to fix it.

Do we have the latest code available somewhere?

 

[ajs]

Do we have the latest code available somewhere?

Yes - https://code.google.com/p/mediaportal-fanart-handler/

 

[HomeY]

FanartHandler.cs (line 1024)

internal void Start()

seems to do a lot of stuff. Maybe it's not supposed to do all that, except when the plugin starts?

My loglines show:

03-Jan-2015 11:30:27  Info [       FanartHandler]: Fanart Handler: is suspended/hibernated.
03-Jan-2015 11:30:27  Info [       FanartHandler]: Fanart Handler: is suspended/hibernated.
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler: is resuming from standby/hibernate.
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler: is resuming from standby/hibernate.

And then it goes from 2 lines to 3:

03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting.
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting.
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler is starting.
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151
03-Jan-2015 11:31:20  Info [       FanartHandler]: Fanart Handler version is 4.0.0.151

It seems OnSystemPowerModeChanged() is triggering start() on resume.

    private void OnSystemPowerModeChanged(object sender, PowerModeChangedEventArgs e)
    {
      try
      {
        if (e.Mode == PowerModes.Resume)
        {
          logger.Info("Fanart Handler: is resuming from standby/hibernate.");
          StopTasks(false);
          Start();
        }

Stop() seems to try to release some of those resources that Start() created, but maybe there are some references left and it fails to release the instances?

 

[ajs]

seems to do a lot of stuff. Maybe it's not supposed to do all that, except when the plugin starts?

In fact, everything is worse, if the MP in the configurator, run in and out of their configurator FH, it will also multiply. He can not behave normally close and destroy. I think from there and feet grow.