Feature request - integrate patched Core.dll (FrameGrabber) for AtmoLight (1 Viewer)

[Sebastiii]

Done

 

[azzuro]

@Owlsroost : can you test this branch ?
https://github.com/MediaPortal/Medi...ces_to_Framegrabber_for_3rd_plugins_Atmolight

@elliottmc : if owlsroot approve than none regression are made by this branch, you can include it for the next build ( if owlsroot found the time ) ?

 

[Sebastiii]

There is a review :
https://issues.team-mediaportal.com/fisheye/cru/MP1CR-115

 

[Owlsroost]

Can someone expalin what the new code does (I'm not a C# programmer) ?

Presumably 'OnNewFrame' only exists if something else i.e. the Atomlight plug-in creates it, so it's null by default ?

How often does the Atmolight plug-in request a frame grab ? Is it calling it from within MP's main render thread (not good), or from a separate thread ?

 

[azzuro]

How often does the Atmolight plug-in request a frame grab ? Is it calling it from within MP's main render thread (not good), or from a separate thread ?

Joker !
this is the official repo of Atmolight : http://sourceforge.net/p/mp-plugins/code/HEAD/tree/trunk/plugins/Atmolight/
@angie05 : can you help on how work Atmolight ?
@gemx : if you read this thread. can you help ?

 

[azzuro]

this is the code line from Atmolightplugin.cs

 void AtmolightPlugin_OnNewFrame(short width, short height, short arWidth, short arHeight, uint pSurface)
{
if (currentEffect != ContentEffect.MP_Live_view)
return;
if (width == 0 || height == 0)
return;
if (rgbSurface==null)
rgbSurface = GUIGraphicsContext.DX9Device.CreateRenderTarget(captureWidth,captureHeight, Format.A8R8G8B8,MultiSampleType.None, 0, true);
unsafe
{
try
{
VideoSurfaceToRGBSurfaceExt(new IntPtr(pSurface), width, height, (IntPtr)rgbSurface.UnmanagedComPointer, captureWidth, captureHeight);
Microsoft.DirectX.GraphicsStream stream = SurfaceLoader.SaveToStream(ImageFileFormat.Bmp, rgbSurface);
BinaryReader reader = new BinaryReader(stream);
stream.Position = 0; // ensure that what start at the beginning of the stream.
reader.ReadBytes(14); // skip bitmap file info header
byte[] bmiInfoHeader = reader.ReadBytes(4 + 4 + 4 + 2 + 2 + 4 + 4 + 4 + 4 + 4 + 4);
byte[] pixelData = reader.ReadBytes((int)(stream.Length - stream.Position));
atmoLiveViewCtrl.setPixelData(bmiInfoHeader, pixelData);
stream.Close();
stream.Dispose();
}
catch (Exception ex)
{
Log.Error(ex);
rgbSurface.Dispose();
rgbSurface = null;
}
}
}

 

[Deda]

Can someone expalin what the new code does (I'm not a C# programmer) ?

Presumably 'OnNewFrame' only exists if something else i.e. the Atomlight plug-in creates it, so it's null by default ?

How often does the Atmolight plug-in request a frame grab ? Is it calling it from within MP's main render thread (not good), or from a separate thread ?

In short, you're right, if there is no any subscriber (some outside class) to that event it will be null.
If there is one, event itself will publish frame parameters width, height, arWidth, arHeight, pSurface and subscriber class will independently do with it what it likes and if that event subscriber do some nasty stuff and hogs cpu it's not our problem (actually it is but we are not the one to blame).

 

[azzuro]

@Owlsroost : we have an other dll for use Atmolight : AtmoDXUtil.dll
http://sourceforge.net/p/mp-plugins/code/HEAD/tree/trunk/plugins/Atmolight/AtmoDXUtil/AtmoDXUtil.cpp

 

[azzuro]

so, no regression for MP user Lambda .

 

[Owlsroost]

If Deda is happy with the patch then I'm OK with it.