Feature request - integrate patched Core.dll (FrameGrabber) for AtmoLight (1 Viewer)

[Dadeo]

I'm a bit lost - we're talking about Issue 4248: Add access to Framegrabber for 3rd plugins (Atmolight) right? which was already added to 1.6 pre-release right?
If so, yes it would be good to make a note of it in Plugin Related Changes > 1.5.0 to 1.6.0 but tbh I have no clue what to say to make it more generic (i.e. not just a patch so Atmolight plugin does not need to modify core) or when/how a plugin dev would use it. Is it enough to say something like "plugins can now access FrameGrabber to capture video stream(s) inside MP renderer." and assume they know what to do correctly???

Do you want to try and create a new page there and I can edit for grammar/English? Good practice azzuro Or I can add the page with what I think is clear from the issue, and you can update it for technical accuracy

 

[azzuro]

Or I can add the page with what I think is clear from the issue, and you can update it for technical accuracy

yes i prefer, only create the location, and i try to add explaination.
but i'm sure, grammar is needed. ( i have ability to learn language easily ( but not from school, i'm anti-system because learn english with " where is bryan? in the kitchen" affraid me lol )

 

[SpudR]

Do your best and it will get amended as it requires.
I was confused reading this too!

 

[Dadeo]

OK I added a FrameGrabber Access to Plugin Related Changes > 1.5.0 to 1.6.0 so all the technical stuff for wiki is done. You can just add anything to Desc of Change if needed to help Plugin Devs know when and how to use the new feature correctly.

I'm not sure what to add under SubSystem when AFAIK it is the main core.dll that has changed.

I reopened the issue and added a Docs Sub-Task. I can close that subtask once you and Seb review and decide if anything more should be added to Wiki page.

 

[azzuro]

Ok, fine
thank you

i think we need to add the change ( code side), for know what is the method for connect to MP.
it's an good stuff, i think.
maybe @angie05 / @gemx can help

 

[vuego]

I added some words I found in this thread to the Description of Change section of the Wiki page. Please have a look to see that I didn't make any mistakes

 

[SpudR]

#Minor corrections to the English