Just to note that there aren't currently any active team members who would be working with the analog tv domain - this is probably the reason why there has been any feedback. I'll try get someone to look at the patch.
[Approved] FM radio signal detection (1 Viewer)
- Thread starter mm1352000
- Start date
Just to note that there aren't currently any active team members who would be working with the analog tv domain - this is probably the reason why there has been any feedback. I'll try get someone to look at the patch.
- September 1, 2008
- 21,577
- 8,224
- Home Country
-
New Zealand
- Thread starter
- #22
I guessed that could be the case. The analog code must be quite mature so doesn't very often need patches. Also with the change to digital TV in many countries, many users just would not use analog tuners any more. The team certainly has higher priorities. Having said that, the code still needs occasional patches - it is not perfect! I've also submitted another simple patch for the crossbar class as well. I'd appreciate it if the team member who looks at this patch could also evaluate that patch too...
- Moderator
- #23
mm135200:
There is already mantis for this issue, 0002445: Hauppauge HVR-2200 cards don't tune FM properly - MediaPortal Bugtracker. You should commit it now
Also, drop by on IRC so we can discuss your other patches..
There is already mantis for this issue, 0002445: Hauppauge HVR-2200 cards don't tune FM properly - MediaPortal Bugtracker. You should commit it now
Also, drop by on IRC so we can discuss your other patches..
- September 1, 2008
- 21,577
- 8,224
- Home Country
-
New Zealand
- Thread starter
- #24
Yeah I *really* want to - you have no idea
Thing is that it is assigned to morpheus_xx. I have PM'd him about it and he said I should talk to MisterD (who is apparently the specialist for analog). There is a [in my opinion, small] risk that this patch could break FM for other users. I will try and contact MisterD when I get home from work this evening...
Thing is that it is assigned to morpheus_xx. I have PM'd him about it and he said I should talk to MisterD (who is apparently the specialist for analog). There is a [in my opinion, small] risk that this patch could break FM for other users. I will try and contact MisterD when I get home from work this evening...
You should bold/emphasize the following sentence of yours:
"The code currently assumes lock if the driver returned -1 or 1. With the patch applied it would assume lock if the driver *doesn't* return zero. The same check, just inverted..."
"The code currently assumes lock if the driver returned -1 or 1. With the patch applied it would assume lock if the driver *doesn't* return zero. The same check, just inverted..."
- September 1, 2008
- 21,577
- 8,224
- Home Country
-
New Zealand
- Thread starter
- #26
Hi everyone
New binary version of the patch for 1.1.0 attached to the first post in the thread. Just ask if you need a binary for a different version - I'll be happy to help...
New binary version of the patch for 1.1.0 attached to the first post in the thread. Just ask if you need a binary for a different version - I'll be happy to help...
Hi everyone
New binary version of the patch for 1.1.0 attached to the first post in the thread. Just ask if you need a binary for a different version - I'll be happy to help...
Hey i tried the new binary...seems to work well
here is my tv.log
View attachment tv.zip
Thanx
Also tested it, and posted my results in this topic.
Not a good result for me unfortunately. Only 4 stations found.
Didn't apply the patch properly, but now it works like a charm! Hope this makes it into trunk!
Not a good result for me unfortunately. Only 4 stations found.
Didn't apply the patch properly, but now it works like a charm! Hope this makes it into trunk!