[fixed] Fullscreen to window moves on the first monitor (1 Viewer)

[Smeulf]

Still at dev branch, steps to reproduce :

- Start MP2 on the secondary monitor

- If M2 start windowed, set it full screen with Alt-Enter, close MP2, and re-start it from monitor 2

- Press Alt-Enter to set it windowed : the window moves on the primary monitor

I think it the windows should be on the secondary monitor instead of the 1st one.

Bug or no bug ?

Cheers.

 

[morpheus_xx]

Hi Yohann,

thanks for reporting this. Unfortunately no one esle seems to have a dual screen setup (me included) to reproduce and fix this issue...

 

[Smeulf]

Well, sounds like I gonna have to submit some patches, if I can figure out how to deal with multiple monitors...

 

[Marcel Horst]

Same experience here. Have a 32" TV and a projector connected to my MP system. Standard Nvidia setup. Maximising MP on projector display pops MP back to TV. Could set graphics card to duplicate image, but optimum resolutions are different on both screens.

 

[Smeulf]

Hi, and thanks Marcel Horst for the confirmation.

I'm currently working on the problem and hopefully it will be fixed very soon.

Cheers.

 

[morpheus_xx]

Hi Smeulf,

did you get further in this part? I have a 2nd screen now available (for next 5 days only!). Can you share your work, maybe I can continue with this...

Thanks
Morpheus

 

[morpheus_xx]

Very good news: https://github.com/MediaPortal/MediaPortal-2/commit/cdc834a46781

You can finally run MP2 on the preferred screen you want Good that I had a 2nd monitor here...

The main issue was, that the already defined location of the MainForm got reset, when it was assigned as DeviceWindowHandle!
https://github.com/MediaPortal/MediaPortal-2/commit/cdc834a46781#L1R496

When I was on it, I also fixed the SplashScreen position and size

 

[chefkoch]

No offense , but I've just reset the thread prefix to [Bug].
I tested your branch and got the following results:

• NO BUG
  Using clean installation (no config files), MP2 Splashscreen and MP2-GUI is displayed fullscreen on primary monitor. This is good.
• NO BUG / Won't be fixed
  When using fullscreen mode the MP2 GUI remembers the screen, which it was closed previously. Nice
  The splash screen is displayed always on primary monitor, even if it was closed on secondary and MP2 will appear on secondary after splash is closed. Splashscreen should be displayed on same monitor like MP2 gui will be displayed.
  Or display it on all availabled screens
• NO BUG
  Set fullscreen mode -> Close MP2 on primary -> Start MP2 -> will be displayed fullscreen on primary -> press ALT+ENTER -> MP2 window still on primary -> press ALT+ENTER again -> fullscreen on primary
• BUG ??? / Potential improvement ???
  Set fullscreen mode -> Close MP2 on secondary -> Start MP2 -> will be displayed fullscreen on secondary -> press ALT+ENTER -> MP2 window is moved to primary -> press ALT+ENTER again -> fullscreen on primary
• BUG ??? / Potential improvement ???
  Starting MP2 in windowed mode always starts it on primary, no matter which position (secondary) it had before closing it. Not sure if starting on primary in windowed mode is bad. But in relation to the previous points it feels inconsistent.

 

[morpheus_xx]

Thanks for testing @chefkoch

Your findings are logical, let me explain:

1. Splashscreen: it will be shown on the screen from where you run MP2 from: if you run it from 2nd screen, it will be visible there.
   • At the lifetime of the splashscreen we do not have any core service yet and thus cannot read any stored setting before. In principle we might try to use ISettingsManager only, but it will require IPathManager and probably more stuff, which is loaded later.
2. Windowed mode: the last position/size of MP2 is not saved at all currently (I guess it's by design as the AppSettings have no properties for this yet). We would need to save position/size in windowed on shutdown so we could restore it on startup.

So IMHO only the 2nd part could be done easily.

 

[chefkoch]

FYI: I update my post to highlight the points using [NO BUG] and [Bug / potential improvement].

As long as we don't change the thread tag, it might not be needed to add it to mantis.