Global Music Search v2.0.0 [2014-02-19] (5 Viewers)

SilentException

Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Home Country
    Croatia Croatia
    here is a .diff and compiled version of the plugin addressing some of the issues mentioned earlier..


    btw, can anyone tell me what should i do in the skin to get support for new sms keyboard? i noticed that black&white does not support sms keyboard and neither the old keyboard doesn't show when called in code in "new style":

    VirtualKeyboard keyboard = new VirtualKeyboard();
    keyboard.Init();

    GUIWindowManager.Replace((int)GUIWindow.Window.WINDOW_VIRTUAL_KEYBOARD, (GUIWindow)keyboard);

    this doesnt work in black&white.. works fine when called like this:

    VirtualKeyboard keyboard = (VirtualKeyboard)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_VIRTUAL_KEYBOARD);

    i'venoticed this behavior both in global search and worldmap (both using new method)..
     

    Attachments

    • GUIGlobalMusicSearch.diff
      30.7 KB
    • GUIGlobalSearch.rar
      30.6 KB

    d-fader

    Portal Pro
    September 24, 2006
    70
    25
    44
    I live in Purmerend, a small town just above Amst
    Home Country
    Netherlands Netherlands
    Hello people,

    First things first. I'm very sorry for my absence lately. Normally I would be very eager to fix bugs and to make improvements, but the last months I just had too much up my sleeve (work, girl, holidays, other private projects) and I just couldn't find the strength to look into GS too. I hope you guys can understand. I'm very much not abandoning the project, I just had to have a little time off from it :)

    That being said: Tonight I'll read through all the postings and I'll try to collect all bugs and wishes and I'll make a list. After that I will slowly begin to spend more time on GS again (mostly I'm like a Diesel train, I start slow but after I'm finally on speed, I'm hard to stop :)).

    That's all I can say for now, have to make diner :)

    Stay tuned!

    PS. thanks for the bugfixes, SilentExcept. My first step will be to add GS to the SVN.
     

    d-fader

    Portal Pro
    September 24, 2006
    70
    25
    44
    I live in Purmerend, a small town just above Amst
    Home Country
    Netherlands Netherlands
    Hi People,

    Check out the first page of this thread for a new version, which is a bugfix release. Have fun (I hope it works, lol). If it works I will post it for the front-page so please let me know your findings. Thanks!

    Pasted from 'Some words from the author':

    February 2nd, 2009
    Okay, so after a few months of true radio silence when you guys needed me most (yeah, the
    'I can only search once bug'), I'm back!
    I'm sorry it all had to take so much time, but I won't abandon this project, I promise
    The good news: I fixed this bug and I requested an SVN login so I can make this plug-in SVN
    controlled.
    Other news: I decided to change the name of this plug-in to 'Global music search'. If/when
    I decide to add more search methods (video's e.g.) I will create a separate plug-in for it.
    This means that the Beta status of this plug-in is removed, since the 'music searching' is
    quite mature. The version number will also not start with 0 anymore (since MP has
    reached the 1.0 milestone). In the future, versions will be built up as follows:
    Major.Minor.Build (where build only contains bugfixes, Minor contains minor enhancements or
    changes and Major is something like a complete rewrite).
    Last but not least: I only fixed this small bug, I guess there will be more bugs and I'll
    address them soon. Also all the requests I got via mail and posts are very appriciated and
    they will all be dealt with, I promise you that, so keep writing !
    I guess that's it, so good luck with this new version and stay tuned!
     

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Home Country
    Croatia Croatia
    working better now "out of the box" :) but there are still problems with saving SearchType status if search hasen't been executed..
    and there is a problem with virtual keyboard on latest svn

    i propose to you another diff with those two fixed
     

    Attachments

    • GUIGlobalMusicSearch.cs.diff
      30.7 KB

    d-fader

    Portal Pro
    September 24, 2006
    70
    25
    44
    I live in Purmerend, a small town just above Amst
    Home Country
    Netherlands Netherlands
    Hi guys, please check out if this version will fix your problems. The keyboard code was quite 'stupid' to begin with. Furthermore I added the code made by SilentExcept and added an icon to the configuration too! The files are attached to this post. The first post in this thread is still the 1.6.3 version.

    Thanks for your support guys!
     

    Attachments

    • GlobalSearch_1.6.4b.mpi
      30.7 KB
    • GlobalSearch_1.6.4b.zip
      30.7 KB
    • GlobalSearch_1.6.4b2.zip
      30.7 KB

    trevor

    Portal Pro
    October 17, 2006
    1,600
    950
    Chelmsford
    Home Country
    United Kingdom United Kingdom
    Since there are no more posts, I guess the issues are solved...? In that case, I'll make a release :)

    Ah...have not tried this version, using 1.6.3 but saw not problems with that. The only issue I had was with the version on LyricsEngine.dll - there is a new version of MyLyrics and the version packaged with the 1.6.3 release breaks it.

    I just reinstalled MyLyrics again and all seems to be ok...have not tested searching Lyrics though.

    Trevor
     

    Users who are viewing this thread

    Top Bottom