[fixed] - Hardcoded Labels in Music Now Playing/Overlays | Page 2

Discussion in 'MediaPortal 1.1.0 RC 1 & 2' started by mortstar, March 25, 2010.

  1. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,451
    Likes Received:
    4,231
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,371 / 0
    Home Country:
    Australia Australia
    Hi Dadeo, for those values in tvseries/streamedmp it was best to have as seperate properties to each value so we can have left aligned under each other which looks way cooler and neater.... To display the odd label here or there though you dont want to provide space for translations and take into account scaling as well e.g.

    Lets say you want to join a few strings together like so in mymusic:

    Track: #Play.Current.Track | Duration: #Play.Current.Duration ==> Track: 03 | Duration: 05:00



    Firstly you need to use a localised string for "Track" and "Duration" as seperate label controls and then take into account super long translations. To code this so it all displays on one line like before would be impossible. You would probably end up something like this:

    Code (Text):
    1.  
    2. Track:               03 |         Duration:                    05:00
    3.  
    This also assumes the ":" is part of the localised strings which it may not be, otherwise we need to create 6 label controls!

    This is why I think if the change is done, a new skin function be added so that functionality isnt lost. And your most likely right, this is probably why it was hardcoded.

    Another way to get around this issue is to wrap localized strings with a keyword so in code, it can do a replace e.g.

    <label>localize(xxx): #Play.Current.Track | localize(yyy): #Play.Current.Duration</label>

    I would be willing to add the code changes for whatever way we can decide on whats best. After 1.1.0 of course :)
     
    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Dadeo
    • Team MediaPortal

    Dadeo Docs Group Manager

    Joined:
    November 26, 2006
    Messages:
    5,340
    Likes Received:
    2,802
    Location:
    Himalayas, India
    Ratings:
    +3,053 / 0
    Home Country:
    Canada Canada
    Show System Specs
    Yep I know. However, the case you use as an example is mainly used for media overlays when music or video is playing.

    Skiinners have the option to display the labels in a non-scrolling format, as some skins have already done in their own media overlays. I can understand that Track is not obvious, however it applies only to music overlays, while video and TV overlays are much more commonly used (for MovPics, TVSeries, Videos, etc) Users I have had feedback from, find the scrolling Duration and Year labels annoying as it takes much longer to see the data, and they can usually recognize a Year or Duration in this context.

    However, I am not arguing with your point, I agree with it. It is an intelligent long term and 'proper' solution imo. I appreciate your proposal. Unfortunately it means we will be stuck with the hard coded labels at least until after MP 1.1.0, because what you propose is a new feature. And it is not even certain that such new features will be considered after MP 1.1.0.
     
    • Like Like x 1
  4. Dadeo
    • Team MediaPortal

    Dadeo Docs Group Manager

    Joined:
    November 26, 2006
    Messages:
    5,340
    Likes Received:
    2,802
    Location:
    Himalayas, India
    Ratings:
    +3,053 / 0
    Home Country:
    Canada Canada
    Show System Specs
    Please note, hard coded labels have been removed in MP 1.1.0 RC3 as of SVN 25661. See the Skin Changes Wiki Page

    Hopefully Damien's proposal will be considered/implemented as soon as the feature freeze is lifted.

    EDIT: Marked the thread as 'fixed'
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!