[Approved] How to Video database section and My Movies get to life (2 Viewers)

[infinite.loop]

Now that 1.1.0 is released, could we please have a patch for this, and binaries, based on 1.1.0 ?

Hopefully if we get some testing done, this can be committed into the trunk for 1.2.0, and we can start releasing SVN builds.

One of our developers allready took a brief look.
He said that the code looks good, but suggested that you should get rid of the hard coded strings that have no place in the code (e.g. when parsing the film description for review, you search for the string "User Review" but that string depends on the source site, it might change in the future and it might be localized).

If you can do that, and build a *.patch based on 1.1.0 final (svn will be tagged today) then I do not see any reason which would prevent this patch from going to the trunk.

In fact, this is the way we would like to see MP1 progressing (Community provides *.patches which the team reviews and commits to svn) while the team focuses on MP2.

 

[Deda]

I'm very glad if I helped on any way to team.

Concerning hardcoded part ( I think there is another one in conflict dialog screen concerning coloring of movie titles), this is a long story as I tried not to touch any other part of MP except My Video related code, but finally I gave up as to fulfill all my ideas, I need to upgrade video database and that User review was made before that. I don't know if IMDB user review is significant to others, but when I'm on IMDB page I always read that review and most of the time review is very interesting. I can put that into database as separate column and hardcoded thing will go away.

All in all, I made all patch not the break other grabbers, they will not give full flavor right now but will continue to work without any problem with all changes I made. Yes I know, I need to think globally but I start all this for my personal needs in the beginning and I never thought to make it public.

Now that 1.1.0 is released, could we please have a patch for this, and binaries, based on 1.1.0 ?

Hopefully if we get some testing done, this can be committed into the trunk for 1.2.0, and we can start releasing SVN builds.

Best wishes,

Mark

I will do that tonight, just to put kids to bed and let my wife to watch True Blood Season 3 Episode 5

 

[Deda]

V 1.1.0 final added

 

[-Manfred-]

Nice to see some enhancements & fixes from users, thx.

So I did not spot anything big during quick try-out but some. Something to do at rainy day if still having interest; stretch config window and see cover art being stretched also - not looking nice, actor movies area has grey bar when stretched also. Then maybe a bit bigger issue is that actor data downloading can not be stopped. Had to click 55 times cancel to stop scanning.

 

[Deda]

Thx for your observation. As rainy is also here and it's weekend I'm quick in this so I fixed all of those flows.
Concerning stretching covers, I'm in doubt how to do that. I change it to proportional stretch so vertical size follows picture box vertical size and it looks ok, but for smaller cover size (this can be mostly on some IMDB covers) picture may be become blurred but it's better than full stretch.

 

[infinite.loop]

Quick question, did you by any chance solve that minor issue on the way while you did the changes?
https://forum.team-mediaportal.com/bugreports-74/minor-labelproblem-mediaportal-config-84804/

 

[Deda]

Not in the current patch as I never try this option but I was quick so this is repaired (it's more cosmetic than fix as this label doesn't have any purpose in this case because everything is already visible what is happening).

Not much to do with that first line except set initial label as "Donwloading..." and when grabbers is processed, set label "Processing..." and update percentage which can't be seen as method is too fast so you will see 0% and 100% in a sec.

And minor repair in counting as now display properly currentitem/maxitems ie. 1/10 to 10/10

File is MovieDatabase.cs

private void mpButtonUpdateGrabber_Click(object sender, EventArgs e)
    {
      if (!Win32API.IsConnectedToInternet())
      {
        MessageBox.Show("Update failed. Please check your internet connection!", "", MessageBoxButtons.OK,
                        MessageBoxIcon.Error);
        return;
      }

      progressDialog = new DlgProgress();
      progressDialog.SetHeading("Updating MovieInfo grabber scripts...");
      progressDialog.TopMost = true;

      // download index file
      progressDialog.SetLine1("Downloading the index file...");
      [B][COLOR="Red"]progressDialog.SetLine2("Downloading...");[/COLOR][/B]
      progressDialog.Total = 1;
      progressDialog.Count = 1;
      progressDialog.Show();
      if (DownloadFile(GrabberIndexFile, GrabberIndexURL) == false)
      {
        progressDialog.CloseProgress();
        return;
      }

      // read index file
      if (!File.Exists(GrabberIndexFile))
      {
        MessageBox.Show("No GrabberIndexFile found.");
        progressDialog.CloseProgress();
        return;
      }
      XmlDocument doc = new XmlDocument();
      doc.Load(GrabberIndexFile);
      XmlNodeList sectionNodes = doc.SelectNodes("MovieInfoGrabber/grabber");

      // download all grabbers
      progressDialog.Total = sectionNodes.Count;
      [B][COLOR="Red"]int percent = 0;[/COLOR][/B]
      for (int i = 0; i < sectionNodes.Count; i++)
      {
        if (progressDialog.DialogResult == DialogResult.Cancel)
        {
          break;
        }
        
        string url = sectionNodes[i].Attributes["url"].Value;
        string id = Path.GetFileName(url);
        progressDialog.SetLine1("Downloading grabber: " + id);
        [B][COLOR="Red"]progressDialog.SetLine2("Processing grabbers...");[/COLOR][/B]
        [B][COLOR="Red"]progressDialog.SetPercentage(percent);[/COLOR][/B]
        progressDialog.Count = [B][COLOR="Red"]i+1;[/COLOR][/B]
        [B][COLOR="Red"]percent += 100 / (sectionNodes.Count - 1);[/COLOR][/B]

Red is changed/added

 

[Gixxer]

Possible new feature you could add:

according to default mp language (or even using internet to localize) ==> AUTOselect some grabbers and organize them.

maybe do an autoupdate of grabbers first.

the idea is to make mp inteligent and help you with the configuration. maybe make it do this auto setup process only first time accesing configuration. rest of the times, do not do it.

hope i am clear on my idea.

 

[catavolt]

AW: How to Video database section and My Movies get to life

Just tested the last version for 1.1.0 and i`m really impressed. This enhancement is really great! big Hope it finds it way into SVN soon

 

[Deda]

Possible new feature you could add:

according to default mp language (or even using internet to localize) ==> AUTOselect some grabbers and organize them.

maybe do an autoupdate of grabbers first.

the idea is to make mp inteligent and help you with the configuration. maybe make it do this auto setup process only first time accesing configuration. rest of the times, do not do it.

hope i am clear on my idea.

It will not be so difficult to accomplish (at least for movie grabbers because they have country ID) except small problem if more grabbers exists for one country and which one to choose or if all, in what order.
And another question is what to use for locale match, Windows locale settings or MP or some other solution.