Integration of MPC-HC subtitle's engine (1 Viewer)

[tourettes]

Thanks, how about unifying the baseclasses version / usage?

What baseclasses are used in mediaportal? In DirectShowFilters readme it is specified to use latest from C:\Program Files\Microsoft SDKs\Windows\v61. I used the same, so it should not be a problem.

So, we need only to modify the solution files to fetch the baseclasses' libs from the same place as the MP diretcshow filters are using. As compiling baseclasses twice is not a best solution for developers (users don't care how it is done )

We have few environment variables to do that "work".

 

[mr viggo]

Great, got this working on my laptop (MP test rig). Having issues though with switching between two different internal subtitles (mkv).

 

[cpp2005]

tourettes
I think we will need two versions of these libs in any case because MPC-HC is compiled statically with runtime while in Mediaportal dynamic linking is used ("multithreaded dll"). It is possible to change it to link dynamically, however they use VS 2008 for compilation so it means C++ 2008 redistributables need to be installed.

mr viggo
Good! What did you see in subtitles selection menu?

 

[tourettes]

tourettes
I think we will need two versions of these libs in any case because MPC-HC is compiled statically with runtime while in Mediaportal dynamic linking is used ("multithreaded dll"). It is possible to change it to link dynamically, however they use VS 2008 for compilation so it means C++ 2008 redistributables need to be installed.

MP might move to VS2008 after 1.0.1 (still not 100% sure, remains to be seen if that brings some new issues on filter side).

 

[mr viggo]

Ok, did some further testing. Subs muxed into mkv doesn't work at all, regardless if there's one or more. The subs menu in MP is not even there. External .srt work fine with PDVD8 & DXVA. Haven't tested more than one .srt and the one I tested is named like the video file.

 

[cpp2005]

Can you attach graphedit screenshot?
For mkv with subtitles, it should look like the attached image.
There should be TextPathThru filter, connected to haali subtitle pin.

 

[mr viggo]

This is how it looks like when either subs are off or on.

 

[seco]

This is how it looks like when either subs are off or on.

So the question is is this supposed to work with EVR ?

 

[magnetism]

No, there is something missing from this implementation it would seem. The MPC-HC solution creates TextPassThrough filter instances which contain a reference to the MPC application. These are then hooked up to the subtitle pins of the Haali splitter.
The filters take case of telling MPC about the subtitles. I'm guessing that part isn't implemented yet.
Still, at least srt subtitles are working now so there is progress

 

[cpp2005]

mr viggo
Can you try other mkv files?

seco
it should work with EVR

magnetism
You are right but it's not missing you can see that I modified TextPassThrough filter, to communicate with my implementation.