Intelligent Frame Correction - PlugIn (1 Viewer)

Marvman

Retired Team Member
  • Premium Supporter
  • November 14, 2007
    1,163
    735
    Bavaria
    Home Country
    Germany Germany
    No only little difference...few milimeters. So it just has to be cut out like you did on the 4:3 in 16:9 image. This is possible right? This is the case on every DVD with cinema wide 21:9 picture.

    We should ask us, why does the zoom mode don't work as expected. IFC could do that, but not in this designed version (too complicated), other user want custom zoom modes too, and for that I have to re-design the IFC from scratch.

    Like the MP devs say, its feature freeze, baby.
     

    Marvman

    Retired Team Member
  • Premium Supporter
  • November 14, 2007
    1,163
    735
    Bavaria
    Home Country
    Germany Germany
    Martin,

    If you can cut the 4:3 image out of the 16:9 video like you did i believe you can do this too. What do i have to do to persuade you? :)

    The problem is not to implement this, IFC isn't designed for, the risk to break the other code is at the moment too high. Maybe I'll build a special version for you.
     

    wouter1971

    MP Donator
  • Premium Supporter
  • November 19, 2008
    910
    143
    Purmerend, Holland
    Home Country
    Netherlands Netherlands
    Martin,

    If you can cut the 4:3 image out of the 16:9 video like you did i believe you can do this too. What do i have to do to persuade you? :)

    The problem is not to implement this, IFC isn't designed for, the risk to break the other code is at the moment too high. Maybe I'll build a special version for you.

    :eek: That would be really nice of you. I'll help you testing anyway i can. :D
     

    wouter1971

    MP Donator
  • Premium Supporter
  • November 19, 2008
    910
    143
    Purmerend, Holland
    Home Country
    Netherlands Netherlands
    Hi Martin,

    Thanks man! I've tested this custom version. My testing results:

    1) Zoom in DVD with black bars working...wow! great!

    Seems to respond to the 4:3 letterbox setting. By the way, if set to normal viewmode i can deside to switch manualy. This works great as some DVD's place the subtitles in the black bar. But fullscreen is possible now. Truly great!

    2) 4:3 in 16:9 black bar scan broken. (this was fixed in last ifc version).

    3) Realy minor issue: Other viewmode settings seem to be hard selected, correction to switch the viewmode manualy is not possible. It will always go back to the selected setting other than the special DVD viewmode which can be selected manualy if you want.
    Or is there a setting for this?


    Will continue testing, if issue 2 is fixed you can release it to the public i think.

    Greetings,

    Wouter
     

    Marvman

    Retired Team Member
  • Premium Supporter
  • November 14, 2007
    1,163
    735
    Bavaria
    Home Country
    Germany Germany
    Hi Martin,

    Thanks man! I've tested this custom version. My testing results:

    1) Zoom in DVD with black bars working...wow! great!

    Seems to respond to the 4:3 letterbox setting. By the way, if set to normal viewmode i can deside to switch manualy. This works great as some DVD's place the subtitles in the black bar. But fullscreen is possible now. Truly great!

    2) 4:3 in 16:9 black bar scan broken. (this was fixed in last ifc version).

    3) Realy minor issue: Other viewmode settings seem to be hard selected, correction to switch the viewmode manualy is not possible. It will always go back to the selected setting other than the special DVD viewmode which can be selected manualy if you want.
    Or is there a setting for this?


    Will continue testing, if issue 2 is fixed you can release it to the public i think.

    Greetings,

    Wouter

    Tested L/R detection and it works here, maybe your scan area for L/R is to big and the logo appears within the area.
    Reduce the height for "L/R Area" and set the y-position down. if this doesn't help send me your logs.

    This version is only for you, cause you need a "wrong" behavior or in other words the zoom view mode that comes from MP doesn't kick in for some DVD's

    To point 3 the view mode is fix, so it will be switch every time back, but the behavior with your DVD wasn't planned :D, but thx for the idea this is a good feature for the future release IFC 2.0 :p
     

    hirscho

    Portal Pro
    December 24, 2006
    186
    20
    Home Country
    Germany Germany
    Hi Marvman

    One question regarding the behaviour of the detection counter. I set it to 3, so that it needs 3 black bar detections to switch from "4:3 ViewMode" to "4:3 Letterbox ViewMode". But it only needs just one detection fail to swicht back from "4:3 Letterbox ViewMode" to "4:3 ViewMode". Wouldn't it be more consistent and user friendly if the detection counter would be valid for both directions?

    Best Regards

    hirscho



    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: perform I.F.C.: g_vmr: 1,333333 (used) ; TV AspectRatio: 1,777778 ; Picture AspectRatio: 0,9444444 ; g_Player.GetVideoFormat(): 4:3
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for control area
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 40 , Y: 45 , Height: 10 , Width: 20
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 217 , Y: 259 , Height: 57 , Width: 108
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 28
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 254
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for black area one
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 30 , Y: 2 , Height: 5 , Width: 40
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 163 , Y: 11 , Height: 28 , Width: 217
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 0
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 1
    2009-11-22 17:28:06.765625 [Debug][I.F.C.: processingThread]: I.F.C.: black bar detected in the first black bar area: count=1
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: perform I.F.C.: g_vmr: 1,333333 (used) ; TV AspectRatio: 1,777778 ; Picture AspectRatio: 0,9444444 ; g_Player.GetVideoFormat(): 4:3
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for control area
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 40 , Y: 45 , Height: 10 , Width: 20
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 217 , Y: 259 , Height: 57 , Width: 108
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 33
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 237
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for black area one
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 30 , Y: 2 , Height: 5 , Width: 40
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 163 , Y: 11 , Height: 28 , Width: 217
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 0
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 2
    2009-11-22 17:28:07.796875 [Debug][I.F.C.: processingThread]: I.F.C.: black bar detected in the first black bar area: count=2
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: perform I.F.C.: g_vmr: 1,333333 (used) ; TV AspectRatio: 1,777778 ; Picture AspectRatio: 0,9444444 ; g_Player.GetVideoFormat(): 4:3
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for control area
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 40 , Y: 45 , Height: 10 , Width: 20
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 217 , Y: 259 , Height: 57 , Width: 108
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 21
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 255
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for black area one
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 30 , Y: 2 , Height: 5 , Width: 40
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 163 , Y: 11 , Height: 28 , Width: 217
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 0
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 4
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: black bar detected in the first black bar area: count=3
    2009-11-22 17:28:08.828125 [Debug][I.F.C.: processingThread]: I.F.C.: 4:3 Letterbox ViewMode: Zoom
    2009-11-22 17:28:09.859375 [Debug][I.F.C.: processingThread]: I.F.C.: perform I.F.C.: g_vmr: 1,333333 (used) ; TV AspectRatio: 1,777778 ; Picture AspectRatio: 0,9444444 ; g_Player.GetVideoFormat(): 4:3
    2009-11-22 17:28:09.859375 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for control area
    2009-11-22 17:28:09.859375 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 40 , Y: 45 , Height: 10 , Width: 20
    2009-11-22 17:28:09.859375 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 217 , Y: 259 , Height: 57 , Width: 108
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 58
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 219
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: scanning for black area one
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in %: X: 30 , Y: 2 , Height: 5 , Width: 40
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: ScanArea in px: X: 163 , Y: 11 , Height: 28 , Width: 217
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Median: 0
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: Gray Max: 37
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: 4:3 ViewMode: NonLinearStretch
    2009-11-22 17:28:09.875000 [Debug][I.F.C.: processingThread]: I.F.C.: tv cropping...
    2009-11-22 17:28:09.875000 [Info.][I.F.C.: processingThread]: PlaneScene: Crop: top:74, bottom:74, left:0, right:0
    2009-11-22 17:28:09.875000 [Info.][I.F.C.: processingThread]: PlaneScene: Crop: top:73, bottom:73, left:0, right:0
     

    gnavox

    Portal Member
    May 13, 2009
    34
    0
    Hi,

    Im suddenly and pretty much out of nowhere experiencing wierd behaviour with the Intelligent Frame Correction plugin. When I listen to music - let it be MP3's or FLAC - and one song ends, so Media Portal will try to start the next song in the folder, Media Portal crashes completely and exists to the Windows desktop.. I have to re-open Media Portal. I know this is related to Intelligent Frame Correction and I can confirm that the problem isn't there when Intelligent Frame Correction is disabled.

    Here is the error log taken from Media Portal after a crash:

    2009-11-24 01:51:30.341463 [ERROR][MPMain]: Exception :confused:ystem.NullReferenceException: Object reference not set to an instance of an object.
    at IntelligentFrameCorrection.IntelligentFrameCorrection.onPlayBackEnded(MediaType mediaType, String filename)
    at MediaPortal.Player.g_Player.EndedHandler.Invoke(MediaType type, String filename)
    at MediaPortal.Player.g_Player.OnEnded()
    at MediaPortal.Player.g_Player.Process()
    at MediaPortalApp.OnProcess()
    at MediaPortal.D3DApp.Application_Idle(Object sender, EventArgs e)
    at System.Windows.Forms.Application.ThreadContext.System.Windows.Forms.UnsafeNativeMethods.IMsoComponent.FDoIdle(Int32 grfidlef)
    at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.Run(Form mainForm)
    at MediaPortalApp.Main(String[] args)
    2009-11-24 01:51:30.342463 [ERROR][MPMain]: Exception :Object reference not set to an instance of an object.
    2009-11-24 01:51:30.342463 [ERROR][MPMain]: site :Void onPlayBackEnded(MediaType, System.String)
    2009-11-24 01:51:30.343463 [ERROR][MPMain]: source :IntelligentFrameCorrection
    2009-11-24 01:51:30.344463 [ERROR][MPMain]: stacktrace: at IntelligentFrameCorrection.IntelligentFrameCorrection.onPlayBackEnded(MediaType mediaType, String filename)
    at MediaPortal.Player.g_Player.EndedHandler.Invoke(MediaType type, String filename)
    at MediaPortal.Player.g_Player.OnEnded()
    at MediaPortal.Player.g_Player.Process()
    at MediaPortalApp.OnProcess()
    at MediaPortal.D3DApp.Application_Idle(Object sender, EventArgs e)
    at System.Windows.Forms.Application.ThreadContext.System.Windows.Forms.UnsafeNativeMethods.IMsoComponent.FDoIdle(Int32 grfidlef)
    at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.Run(Form mainForm)
    at MediaPortalApp.Main(String[] args)
    2009-11-24 01:51:30.345463 [ERROR][MPMain]: MediaPortal stopped due to an exception Object reference not set to an instance of an object. IntelligentFrameCorrection at IntelligentFrameCorrection.IntelligentFrameCorrection.onPlayBackEnded(MediaType mediaType, String filename)
    at MediaPortal.Player.g_Player.EndedHandler.Invoke(MediaType type, String filename)
    at MediaPortal.Player.g_Player.OnEnded()
    at MediaPortal.Player.g_Player.Process()
    at MediaPortalApp.OnProcess()
    at MediaPortal.D3DApp.Application_Idle(Object sender, EventArgs e)
    at System.Windows.Forms.Application.ThreadContext.System.Windows.Forms.UnsafeNativeMethods.IMsoComponent.FDoIdle(Int32 grfidlef)
    at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
    at System.Windows.Forms.Application.Run(Form mainForm)
    at MediaPortalApp.Main(String[] args)
     

    Users who are viewing this thread

    Top Bottom