Internet Radio Stream has to be selected twice (1 Viewer)

[Snoopy87]

MediaPortal Version: 1.3.0

Description
Hi,
I'm using Internet Radio Streams with the default Radio plug-in of MediaPortal. When switching between them, I have to click two times on an entry. This only happens with Internet Radio Streams, not with DVB-S Radio Streams.

Regards,
Sascha

Steps to Reproduce:
1. Go to TV Server Configuration
2. Add at least two Internet Radio Streams as Radio Channel to the Radio section
3. Add those channels to your group which includes normal DVB-S radio channels
4. Start MediaPortal and got to "Radio"
5. Select an Internet Radio Stream, click OK and it will play
6. Select another Internet Radio Stream, click OK and nothing will happen. Click "OK" again, it will play

 

[jameson_uk]

Need logs I debug mode

 

[Holzi]

I think I noticed something similar with RadioTime streams. But need to test again.

 

[Sebastiii]

I can confirm this for webstream so we need to compare log about it

 

[HomeY]

Confirmed. Debug logs attached.

0004464: Starting playback of Radio webstream (while radio is playing) stops playback

 

[Holzi]

Related to BASS rework?

 

[HomeY]

Related to BASS rework?

That's possible (and that's missing a GetStreamTag).\
@jameson_uk i've assigned the mantis to you, but not sure if it needs to be hwahrmann

 

[jameson_uk]

MediaPortal Version: 1.3.0

Related to BASS rework?

This is 1.3 so not going to be related to BASS rework.
I have a feeling internet radio via TV server does not use BASS at all anyway.
Will need to investigate when I have some spare time

 

[Holzi]

Well I had/have the problem with RadioTime. It worked fine in MP 1.3.0. Maybe it is because of the removel of GetStreamTag like @HomeY said.

 

[jameson_uk]

Just comments as I am quite confused as there is a load of horrible old code around here...

We get into OnClick in Radio.cs which goes through, identifies that it is a radio webstream and plays it

[2013-05-25 15:17:45,223] [Log	] [MPMain   ] [INFO ] - OnClick
[2013-05-25 15:17:45,240] [Log	] [MPMain   ] [INFO ] - g_Player.PlayAudioStream(http://82.201.100.12:8000/radio538.m3u)

Then you click another channel and you have

[2013-05-25 15:17:51,950] [Log	] [MPMain   ] [INFO ] - OnClick
[2013-05-25 15:17:51,964] [Log	] [MPMain   ] [DEBUG] - g_Player.doStop() keepTimeShifting = False keepExclusiveModeOn = False
[2013-05-25 15:17:51,965] [Log	] [MPMain   ] [INFO ] - g_Player.OnStopped()
[2013-05-25 15:17:51,971] [Log	] [MPMain   ] [INFO ] - RadioRecorded:OnPlayRecordingBackStopped Radio http://82.201.100.12:8000/radio538.m3u
[2013-05-25 15:17:51,973] [Log	] [MPMain   ] [INFO ] - RadioRecorded:OnPlayRecordingBackStopped no recording found with filename http://82.201.100.12:8000/radio538.m3u
[2013-05-25 15:17:51,974] [Log	] [MPMain   ] [INFO ] - TvRecorded:OnPlayRecordingBackStopped Radio http://82.201.100.12:8000/radio538.m3u
[2013-05-25 15:17:51,976] [Log	] [MPMain   ] [DEBUG] - g_Player.doStop() - stop
[2013-05-25 15:17:51,979] [Log	] [BASS Stop] [DEBUG] - BASS: Stop of stream http://82.201.100.12:8000/radio538.m3u.
[2013-05-25 15:17:51,980] [Log	] [BASS Stop] [DEBUG] - BASS: Disposing Music Stream http://82.201.100.12:8000/radio538.m3u
[2013-05-25 15:17:51,980] [Log	] [BASS Stop] [DEBUG] - BASS: Stopping WASAPI Device
[2013-05-25 15:17:51,981] [Log	] [BASS Stop] [DEBUG] - BASS: Disposing Mixer Stream
[2013-05-25 15:17:51,984] [Log	] [MPMain   ] [INFO ] - g_Player.PlayAudioStream(http://www.skyradio.nl/player/skyradio.pls)

So original stream is stopped but it says new one is started
and we have

[2013-05-25 15:17:52,407] [Log	] [MPMain   ] [INFO ] - g_Player.OnStarted() http://www.skyradio.nl/player/skyradio.pls media:Radio

to say this has actually started but then we get

[2013-05-25 15:17:52,407] [Log	] [MPMain   ] [DEBUG] - TVHome.GetPreferedAudioStreamIndex(): preferred LANG(s):n/a preferAC3:True _preferAudioTypeOverLang:True
[2013-05-25 15:17:52,407] [Log	] [MPMain   ] [DEBUG] - Audio streams avail: 1
[2013-05-25 15:17:52,407] [Log	] [MPMain   ] [INFO ] - Audio stream: switching to preferred AC3/MPEG audio stream 0 (only 1 track avail.)
[2013-05-25 15:17:52,407] [Log	] [MPMain   ] [DEBUG] - RadioRecorded.OnPlayRecordingBackStarted(): setting audioIndex on tsreader 0
[2013-05-25 15:17:52,414] [Log	] [MPMain   ] [DEBUG] - D3D: OnPaint()
[2013-05-25 15:17:52,414] [Log	] [MPMain   ] [INFO ] - g_Player.Process() player stopped...
[2013-05-25 15:17:52,414] [Log	] [MPMain   ] [INFO ] - g_Player.OnEnded()
[2013-05-25 15:17:52,417] [Log	] [MPMain   ] [DEBUG] - g_Player.doStop() keepTimeShifting = False keepExclusiveModeOn = False
[2013-05-25 15:17:52,417] [Log	] [MPMain   ] [DEBUG] - g_Player.doStop() - stop

So next stop is f_player.Process which has

	  if (!_player.Playing)
	  {
		Log.Info("g_Player.Process() player stopped...");
		if (_player.Ended)
		{
		  OnEnded();
		  GUIMessage msg = new GUIMessage(GUIMessage.MessageType.GUI_MSG_PLAYBACK_ENDED, 0, 0, 0, 0, 0, null);
		  GUIWindowManager.SendThreadMessage(msg);
		  GUIGraphicsContext.IsFullScreenVideo = false;
		  GUIGraphicsContext.IsPlaying = false;
		  GUIGraphicsContext.IsPlayingVideo = false;
		  return;
		}
		Stop();
	  }

Which appears to be where this stop comes from.

All looks like some sort of timing issue (although I don't know if / why stop is being called in OnClick) need to debug this properly when can get access to my proper dev machine