Internet Radio Stream has to be selected twice (4 Viewers)

[Holzi]

Thanks for investigiating!

 

[Sebastiii]

This is a binary for testing.

We need to test regression, but effectively, radio stream is already stopped when clicking on new stream and an another windows message is send to stop a second time.

I comment out that part and need regression testing for sure

 

[Sebastiii]

Hi,

I think i have found where it failed, so i don't really know if above bin is the full fix lol

It's for sure sort of timing issue :
In Bassengine code (the stop is started in a separate thread) and it's : 'HandleSongEnded();' that init '_state = PlayState.Ended;' and then it stop the stream when it was already started, so need a second click to start it again.

@hwahrmann do you have an idea for this ? (maybe avoid this init for radio ?) like it seems that the stream stop between click.

Thanks

 

[jameson_uk]

It's for sure sort of timing issue :
In Bassengine code (the stop is started in a separate thread) and , xxxit's : 'HandleSongEnded();' that init '_state = PlayState.Ended;' and then it stop the stream when it was already started, so need a second click to start it again.

The code works for normal audio so there must be an issue in how we start playback. This is done via PlayAudioStream rather than just Play but I spent a while trying to figure out the difference last night without success.

 

[Sebastiii]

+1

Will try again this night / evening

 

[Sebastiii]

This is the WIP patch (working for me)

 

[Sebastiii]

I forgot part2 lol

 

[Sebastiii]

Attached bin for testing

Of course that need testing with DVB Radio / Streaming plugins etc.

 

[Snoopy87]

Thanks a lot!

Are the bin files based on 1.4? Because I have installed the 1.4 Pre-Alpha and want to test your changes.

 

[Sebastiii]

Should be ok yes bin are based on current master but it should work.