Internet Radio Stream has to be selected twice (1 Viewer)

Holzi

Super Moderator
  • Team MediaPortal
  • April 21, 2010
    7,934
    2,235
    Ba-Wü
    Home Country
    Germany Germany
    Thanks for investigiating! :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    This is a binary for testing.

    We need to test regression, but effectively, radio stream is already stopped when clicking on new stream and an another windows message is send to stop a second time.

    I comment out that part and need regression testing for sure :)
     

    Attachments

    • Core_Radio_Webstream.zip
      1.1 MB

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hi,

    I think i have found where it failed, so i don't really know if above bin is the full fix lol

    It's for sure sort of timing issue :
    In Bassengine code (the stop is started in a separate thread) and it's : 'HandleSongEnded();' that init '_state = PlayState.Ended;' and then it stop the stream when it was already started, so need a second click to start it again.

    @hwahrmann do you have an idea for this ? (maybe avoid this init for radio ?) like it seems that the stream stop between click.

    Thanks :)
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    It's for sure sort of timing issue :
    In Bassengine code (the stop is started in a separate thread) and , xxxit's : 'HandleSongEnded();' that init '_state = PlayState.Ended;' and then it stop the stream when it was already started, so need a second click to start it again.

    The code works for normal audio so there must be an issue in how we start playback. This is done via PlayAudioStream rather than just Play but I spent a while trying to figure out the difference last night without success.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    This is the WIP patch (working for me) :)
     

    Attachments

    • 0001-WIP-Webstream-Radio-fix.patch
      1.7 KB

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    I forgot part2 lol :)
     

    Attachments

    • 0001-WIP-Webstream-Radio-fix-Part2.patch
      921 bytes

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Attached bin for testing :)

    Of course that need testing with DVB Radio / Streaming plugins etc.
     

    Attachments

    • Core_TvPlugin_Webstream_Fix.zip
      1.3 MB

    Snoopy87

    Portal Pro
    August 12, 2012
    470
    167
    Home Country
    Germany Germany
    Thanks a lot!

    Are the bin files based on 1.4? Because I have installed the 1.4 Pre-Alpha and want to test your changes.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Should be ok yes :) bin are based on current master but it should work.
     

    Users who are viewing this thread

    Top Bottom