[MANTIS 4331] - TvService crash when tune cancelled in same time as received new PMT (1 Viewer)

[elliottmc]

Ready for testing and scheduled for MP 1.4.0?!

Has it had any testing? In general I'd prefer to know that something has been tested by at least one more person before scheduling for 1.4.0.

Right now, it's getting hard to keep track of fixes for 1.4.0, and I don't want to have to push out a new internal test build every 2 days or it will just wear people down.

 

[georgius]

Because this bug is causing crashing of TV Service I prefer to fix this in next release (1.3.1).

 

[elliottmc]

Because this bug is causing crashing of TV Service I prefer to fix this in next release (1.3.1).

As far as we are currently planning there won't be a 1.3.1.

Bottom line - how many people have tested?

 

[georgius]

I made only quick test. Today evening I'm planning to make deeper tests (with and without fixed bug) with hard-coded exceptions (because is hard to simulate right situation).

 

[georgius]

I made deeper test with not-fixed TV service and result is that TV service didn't crash. I modified TsWriter to see, if something is returned from TV service callback and on callback exception is returned COR_E_EXCEPTION (0x80131500). I don't have any idea how this unhandled exception occurred. In fixed version is exception always catched.

 

[elliottmc]

I made deeper test with not-fixed TV service and result is that TV service didn't crash. I modified TsWriter to see, if something is returned from TV service callback and on callback exception is returned COR_E_EXCEPTION (0x80131500). I don't have any idea how this unhandled exception occurred. In fixed version is exception always catched.

So, you are happy that this fixes the problem and causes no regression? It is in the new build I just posted.

 

[georgius]

So, you are happy that this fixes the problem and causes no regression? It is in the new build I just posted.

It fixes only consequence of problem, not cause of problem. But at least TV service doesn't crash.

 

[elliottmc]

So, you are happy that this fixes the problem and causes no regression? It is in the new build I just posted.

It fixes only consequence of problem, not cause of problem. But at least TV service doesn't crash.

But it does exactly what it is intended to do? If so, and you are 100% confident, we should merge this to master and move on!

 

[georgius]

Yes, it does and I'm 100% confident.

 

[Sebastiii]

Hi Guys,

Thanks Georgious, but it could be nice to find root of cause and open a new mantis for it ?
Seb.