[solved] MiniDisplayPlugin: Support for latest iMON VFD/LCD drivers (1 Viewer)

[Stéphane Lenclud]

@regeszter So what's the difference with putting a patch in this forum? What's the preferred way? Do I have to clone the repo with write access? Any pointer to the process description welcome.

@Sebastiii

Do we have a branch or Jira for it ?
Sorry i didn't follow the thread.

Just a local branch. No JIRA either. I'm new there you need to teach me guys

 

[regeszter]

I think the patch is good for us but @Sebastiii is the master.

 

[azzuro]

@Sebastiii
yes, we have already an branch & Jira ticket.
but was coded without nuget package, and tourette ask me to don't add more external binary to the MePo project.
https://issues.team-mediaportal.com/browse/MP1-4075
https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4075-Add_Imon_Display_API_to_Minidisplay

so, i think this new rework, is better than the old. maybe rebase the old by the new one.

 

[azzuro]

@Stéphane Lenclud
i'm sorry to ask you for that, can you verify the comment of @tourettes for imon display integration ?

https://github.com/MediaPortal/Medi...51ef4c04ef970c8d11d78d320a40dc950d75#comments
seems to be have, a bit error to code, for don't break MP.

thanks

 

[Sebastiii]

It seems the path is totally new so if true tourettes comment are not needed but need confirmation

 

[azzuro]

It seems the path is totally new so if true tourettes comment are not needed but need confirmation

i think the rework of stephane is based on stephanurik fist work ( what is added to the branch ).
Hum all Stephane have imon device ???

 

[Sebastiii]

So need to know
For example, if i create a new branch + patch in first post + nuget dll only : should it work ? (if yes i will rebase the branch to do it like describe lol after that need to know how to get nuget package (the official one) from our MP nuget )
Thanks.

 

[Sebastiii]

Where should go :
iMONDisplay.dll and iMONDisplayWrapper.dll ?
Nuget works

 

[azzuro]

iMONDisplay.dll and iMONDisplayWrapper.dll ?

in minidisplay driver folder for me.

 

[Sebastiii]

Thanks
In fact i understand it lol,
So i have setup the nuget package (i mean take the bin) and modified the setup.nsi and postbuild.bat.
So installer auto copy dll etc.

Now just to know if only fisrt patch is only needed (because if not, we need to solve code based on Tourettes comment)