[solved] MiniDisplayPlugin: Support for latest iMON VFD/LCD drivers (2 Viewers)

[azzuro]

Can I create a new branch on github to manage this instead of dumb patches? Do I need some level of permission to do that?

no, you can't, but you can create your own fork of MP, and push on your own branch.

Ideally MiniDisplay plug-in should be taken out of the MP core but I guess that's beyond the scope of those changes.

we working on the split of windowplugins.dll for easy update & bugfix.
Minidisplay was an external plugin. for github i try to create an small "how to" for help "new" dev.

 

[Sebastiii]

With the recent master.
Minidisplay didn't compil because of removing weather part so need to be fixed too

 

[Stéphane Lenclud]

@Sebastii Yes I did fix the compilation errors but the feature won't be working now. If you can tip me on how to get it to work that would be great.
Here is a pull request:
https://github.com/MediaPortal/MediaPortal-1/pull/33

Hopefully I did it right.

 

[Sebastiii]

That's the point, i don't know like it seems old weather code was removed (because not used), so maybe we shoudn't remove it ?
@elliottmc @seco what do you think ? (remove the weather stuff break minidisplay or now minidisplay should talk with weather lite ?)

 

[elliottmc]

That's the point, i don't know like it seems old weather code was removed (because not used), so maybe we shoudn't remove it ?
@elliottmc @seco what do you think ? (remove the weather stuff break minidisplay or now minidisplay should talk with weather lite ?)

Old weather code was removed because it was no longer working. I think it is better to remove the code and use a plugin than to leave in (and try to use) non-functional code.

Are the minidisplay plugins part of MP core? If so, I guess we need to do something about this. However, this will really involve more settings to choose the weather plugin to use (WorldWeather/WorldWeatherLite).

 

[seco]

I don't know why anything should reference or use GUIWeather if it's not maintained and even not working anymore..

 

[Stéphane Lenclud]

All what's needed by mini display is to know whether or not we are currently displaying the weather so that it can light up an icon.
See: https://forum.team-mediaportal.com/...ver-for-mediaportal-1-1-3-1-2-1.95616/page-24
Source is there: https://github.com/Slion/MediaPortal-1/commit/7d30e2a3ac3e5e64312dc4e03ac4c6474b05613e
Search for "weather".[DOUBLEPOST=1390897310][/DOUBLEPOST]

Are the minidisplay plugins part of MP core?

Yes they are.

 

[seco]

Well the window ID for weather should be ID of WorldWeather or what ever is used to show weather...

 

[Stéphane Lenclud]

ID of WorldWeather

Where can I find its definition and value?

 

[Sebastiii]

@Sebastii Yes I did fix the compilation errors but the feature won't be working now. If you can tip me on how to get it to work that would be great.
Here is a pull request:
https://github.com/MediaPortal/MediaPortal-1/pull/33

Hopefully I did it right.

I have take your repo on my local one : https://github.com/Slion/MediaPortal-1/tree/MiniDisplayImonBase
Does it this branch the latest ? (i'm not sure)

Can you create a branch based on master + your changes ? and i will push it on a new branch on MP1 official repo
Thanks